Turn the unresolved-references list into a linked list using the VariableProxies themselves

Turn the unresolved-references list into a linked list using the VariableProxies themselves

This is a first step towards reducing memory usage by scopes in the parser. Peak zone memory usage on octane-codeload goes down by ~10%

BUG=

Committed: https://crrev.com/c908f4b8dfa9ae0ebf103afe3fa99564970e1804
Cr-Commit-Position: refs/heads/master@{#37840}

[Toon Verwaest, 2016-07-18 11:04:15]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2016-07-18 11:43:44]

verwaest@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Toon Verwaest, 2016-07-18 11:43:45]

ptal

[Toon Verwaest, 2016-07-18 11:44:38]

Description was changed from

==========
Turn the unresolved-references list into a linked list using the VariableProxies
themselves

BUG=
==========

to

==========
Turn the unresolved-references list into a linked list using the VariableProxies
themselves

This is a first step towards reducing memory usage by scopes in the parser. Peak
zone memory usage on octane-codeload goes down by ~10%

BUG=
==========

[Michael Starzinger, 2016-07-18 13:03:24]

LGTM.

https://codereview.chromium.org/2159573002/diff/40001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2159573002/diff/40001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:840: while (current != nullptr) {
nit: Could we write this as follows for readability ...

for (VariableProxy* proxy = unresolved_; proxy != nullptr; proxy =
proxy->next_unresolved()) { ... }

https://codereview.chromium.org/2159573002/diff/40001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:1238: while (current != nullptr) {
nit: Likewise.

[Toon Verwaest, 2016-07-18 13:26:02]

That does make it much nicer, thanks :)

[Toon Verwaest, 2016-07-18 13:26:07]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-07-18 13:26:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2159573002/#ps60001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-07-18 13:26:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 13:54:05]

Description was changed from

==========
Turn the unresolved-references list into a linked list using the VariableProxies
themselves

This is a first step towards reducing memory usage by scopes in the parser. Peak
zone memory usage on octane-codeload goes down by ~10%

BUG=
==========

to

==========
Turn the unresolved-references list into a linked list using the VariableProxies
themselves

This is a first step towards reducing memory usage by scopes in the parser. Peak
zone memory usage on octane-codeload goes down by ~10%

BUG=
==========

[commit-bot: I haz the power, 2016-07-18 13:54:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-18 13:56:32]

Description was changed from

==========
Turn the unresolved-references list into a linked list using the VariableProxies
themselves

This is a first step towards reducing memory usage by scopes in the parser. Peak
zone memory usage on octane-codeload goes down by ~10%

BUG=
==========

to

==========
Turn the unresolved-references list into a linked list using the VariableProxies
themselves

This is a first step towards reducing memory usage by scopes in the parser. Peak
zone memory usage on octane-codeload goes down by ~10%

BUG=

Committed: https://crrev.com/c908f4b8dfa9ae0ebf103afe3fa99564970e1804
Cr-Commit-Position: refs/heads/master@{#37840}
==========

[commit-bot: I haz the power, 2016-07-18 13:56:33]

Patchset 3 (id:??) landed as
https://crrev.com/c908f4b8dfa9ae0ebf103afe3fa99564970e1804
Cr-Commit-Position: refs/heads/master@{#37840}

[adamk, 2016-07-18 16:54:33]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-07-18 16:54:34]

https://codereview.chromium.org/2159573002/diff/60001/src/ast/scopes.cc
File src/ast/scopes.cc (left):

https://codereview.chromium.org/2159573002/diff/60001/src/ast/scopes.cc#oldco...
src/ast/scopes.cc:112: unresolved_(16, zone),
I wonder if it was this 16 that was causing excess peak usage. Otherwise I'd
have expected that adding a word to every VariableProxy would be more expensive.