Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3634)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java

Issue 2159533002: Add a section to Site Settings listing USB devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_usb_settings
Patch Set: Restore automatic dismissal behavior and fix a bug while searching. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java
index c48aa1e67453b2924b4b259831a54ea7e39d0edf..3da87b4e23bacfa05deee52f5584c6a129434c6b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/UsbInfo.java
@@ -8,6 +8,9 @@ import java.io.Serializable;
/**
* USB device information for a given origin.
+ *
+ * These objects are compared only by the identity of the device, not by which site has permission
+ * to access it.
*/
public class UsbInfo implements Serializable {
private final String mOrigin;
@@ -49,4 +52,18 @@ public class UsbInfo implements Serializable {
public void revoke() {
WebsitePreferenceBridge.nativeRevokeUsbPermission(mOrigin, mEmbedder, mObject);
}
+
+ @Override
+ public int hashCode() {
+ return mObject.hashCode();
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj instanceof UsbInfo) {
+ UsbInfo other = (UsbInfo) obj;
+ return mObject.equals(other.mObject);
+ }
+ return false;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698