chrome/android/java/res/xml/single_object_preferences.xml - Issue 2159533002: Add a section to Site Settings listing USB devices.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/xml/single_object_preferences.xml

Issue 2159533002: Add a section to Site Settings listing USB devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_usb_settings

Patch Set: Add comment explaining the automatic dismiss behavior. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/xml/single_chooser_preferences.xml ('k') | chrome/android/java/res/xml/site_settings_preferences.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">

	7 <Preference

	8 android:key="object_name"

	9 android:widgetLayout="@layout/usb_permission" />
	Ted C 2016/08/15 20:31:59 this seems more specific than the name of the file this seems more specific than the name of the file suggests. should this be renamed usb_[chooser\|device]_preferences.xml based on the other renames? Reilly Grant (use Gerrit) 2016/08/16 17:41:59 Done. Show quoted text On 2016/08/15 at 20:31:59, Ted C wrote: > this seems more specific than the name of the file suggests. should this be renamed usb_[chooser\|device]_preferences.xml based on the other renames? Done.
	10 <Preference

	11 android:key="divider"

	12 android:layout="@layout/divider_preference" />

	13 </PreferenceScreen>

OLD	NEW