cc/proto/layer_tree.proto - Issue 2159513003: Setup LayerTree class, refactor 2 functions from LayerTreeHost to it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/proto/layer_tree.proto

Issue 2159513003: Setup LayerTree class, refactor 2 functions from LayerTreeHost to it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Layer GetLayerTree now directly uses LayerTree pointer. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 syntax = "proto2";	5 syntax = "proto2";

6	6

7 import "rect.proto";	7 package cc.proto;

8	8

9 option optimize_for = LITE_RUNTIME;	9 option optimize_for = LITE_RUNTIME;

10	10

11 package cc.proto;	11 message LayerTree {

12	12 repeated int32 layers_that_should_push_properties = 1;
	vmpstr 2016/07/28 21:43:22 Maybe we should name these with "id" in the name, Maybe we should name these with "id" in the name, kind of like layer_ids_that_should_push_properties?
13 message Region {	13 optional bool in_paint_layer_contents = 2;
	vmpstr 2016/07/28 21:43:22 This looks like it's a transitive state that shoul This looks like it's a transitive state that shouldn't be serialized. That is, it is temporarily true, but mostly false. Khushal 2016/07/28 21:52:20 Yup, the aim is to move stuff that actually needs Show quoted text On 2016/07/28 21:43:22, vmpstr wrote: > This looks like it's a transitive state that shouldn't be serialized. That is, > it is temporarily true, but mostly false. Yup, the aim is to move stuff that actually needs to be serialized into seperate structs, so both computed and helper variables are not serialized.
14 repeated Rect rects = 1;

15 }	14 }

OLD	NEW

« no previous file with comments | « cc/proto/BUILD.gn ('k') | cc/proto/layer_tree_host.proto » ('j') | no next file with comments »