Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2159423002: Remove Enable Exits On Suspend flags on iOS (Closed)

Created:
4 years, 5 months ago by gambard
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Enable Exits On Suspend flags on iOS This CL removes the Enable Exits On Suspend flag on iOS. BUG=627859 Committed: https://crrev.com/242ab8228ed67413dc6a2f1f840b145b9b434633 Cr-Commit-Position: refs/heads/master@{#406543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -144 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/chrome/app/UIApplication+ExitsOnSuspend.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ios/chrome/app/UIApplication+ExitsOnSuspend.mm View 1 chunk +0 lines, -110 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
gambard
Created Reland of move Enable Exits On Suspend flags on iOS
4 years, 5 months ago (2016-07-20 08:23:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159423002/1
4 years, 5 months ago (2016-07-20 08:24:16 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-20 08:24:17 UTC) #5
gambard
PTAL
4 years, 5 months ago (2016-07-20 08:25:32 UTC) #6
sdefresne
Can you update the description to be the same as original CL (i.e. remove all ...
4 years, 5 months ago (2016-07-20 08:54:41 UTC) #7
sdefresne
lgtm
4 years, 5 months ago (2016-07-20 08:54:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159423002/1
4 years, 5 months ago (2016-07-20 09:43:34 UTC) #11
lpromero
lgtm
4 years, 5 months ago (2016-07-20 09:43:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 13:08:33 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 13:10:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/242ab8228ed67413dc6a2f1f840b145b9b434633
Cr-Commit-Position: refs/heads/master@{#406543}

Powered by Google App Engine
This is Rietveld 408576698