third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

index ed2c72d3b5fd26e0473564733010ba18d47dac4e..0e9907a9e0824ab0031c14eb85e56a17d4d1a2fb 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

@@ -76,7 +76,7 @@ void MediaStreamAudioDestinationHandler::process(size_t numberOfFrames)

void MediaStreamAudioDestinationHandler::setChannelCount(unsigned long channelCount, ExceptionState& exceptionState)

{

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

// Currently the maximum channel count supported for this node is 8,

// which is constrained by m_source (WebAudioCapturereSource). Although