Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp b/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
index e6ce38fa817d88144cc187147fca08ec70ac9451..490b40b3aa529691a133022aba51f6150d062924 100644
--- a/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
@@ -15,8 +15,8 @@ IIRProcessor::IIRProcessor(float sampleRate, size_t numberOfChannels, const Vect
{
unsigned feedbackLength = feedbackCoef.size();
unsigned feedforwardLength = feedforwardCoef.size();
- ASSERT(feedbackLength > 0);
- ASSERT(feedforwardLength > 0);
+ DCHECK_GT(static_cast<int>(feedbackLength), 0);
+ DCHECK_GT(static_cast<int>(feedforwardLength), 0);
Raymond Toy 2016/07/25 16:56:52 DCHECK_GT(..., 0u)
HyungwookLee 2016/07/26 00:42:40 Done.
m_feedforward.allocate(feedforwardLength);
m_feedback.allocate(feedbackLength);
@@ -25,7 +25,7 @@ IIRProcessor::IIRProcessor(float sampleRate, size_t numberOfChannels, const Vect
// Need to scale the feedback and feedforward coefficients appropriately. (It's up to the caller
// to ensure feedbackCoef[0] is not 0!)
- ASSERT(feedbackCoef[0] != 0);
+ DCHECK_NE(feedbackCoef[0], 0);
if (feedbackCoef[0] != 1) {
// The provided filter is:

Powered by Google App Engine
This is Rietveld 408576698