third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

index 8daf32de2a7b32c8c77c45f029eafb04a11dab43..98b1f41f6840e3ccab368a00f2b628aa1377dee7 100644

--- a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

@@ -149,7 +149,7 @@ bool BiquadFilterNode::setType(unsigned type)

void BiquadFilterNode::getFrequencyResponse(const DOMFloat32Array* frequencyHz, DOMFloat32Array* magResponse, DOMFloat32Array* phaseResponse)

{

- ASSERT(frequencyHz && magResponse && phaseResponse);

+ DCHECK(frequencyHz && magResponse && phaseResponse);

Raymond Toy 2016/07/25 16:56:52 Perhaps split this into 3 DCHECK's for each part.

HyungwookLee 2016/07/26 00:42:40 Done.

int n = std::min(frequencyHz->length(), std::min(magResponse->length(), phaseResponse->length()));

if (n)