Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp b/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
index 090af4fb4db370449e63595a7cb6239828f79078..87dd1f9d59fe86929c862e8c4e7333932a109ad1 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
@@ -85,7 +85,7 @@ void AudioNodeInput::disconnect(AudioNodeOutput& output)
void AudioNodeInput::disable(AudioNodeOutput& output)
{
ASSERT(deferredTaskHandler().isGraphOwner());
- ASSERT(m_outputs.contains(&output));
+ DCHECK(m_outputs.contains(&output));
m_disabledOutputs.add(&output);
m_outputs.remove(&output);
@@ -98,7 +98,7 @@ void AudioNodeInput::disable(AudioNodeOutput& output)
void AudioNodeInput::enable(AudioNodeOutput& output)
{
ASSERT(deferredTaskHandler().isGraphOwner());
- ASSERT(m_disabledOutputs.contains(&output));
+ DCHECK(m_disabledOutputs.contains(&output));
// Move output from disabled list to active list.
m_outputs.add(&output);
@@ -116,7 +116,7 @@ void AudioNodeInput::didUpdate()
void AudioNodeInput::updateInternalBus()
{
- ASSERT(deferredTaskHandler().isAudioThread());
+ DCHECK(deferredTaskHandler().isAudioThread());
ASSERT(deferredTaskHandler().isGraphOwner());
unsigned numberOfInputChannels = numberOfChannels();
@@ -150,7 +150,7 @@ unsigned AudioNodeInput::numberOfChannels() const
AudioBus* AudioNodeInput::bus()
{
- ASSERT(deferredTaskHandler().isAudioThread());
+ DCHECK(deferredTaskHandler().isAudioThread());
// Handle single connection specially to allow for in-place processing.
if (numberOfRenderingConnections() == 1 && handler().internalChannelCountMode() == AudioHandler::Max)
@@ -162,19 +162,20 @@ AudioBus* AudioNodeInput::bus()
AudioBus* AudioNodeInput::internalSummingBus()
{
- ASSERT(deferredTaskHandler().isAudioThread());
+ DCHECK(deferredTaskHandler().isAudioThread());
return m_internalSummingBus.get();
}
void AudioNodeInput::sumAllConnections(AudioBus* summingBus, size_t framesToProcess)
{
- ASSERT(deferredTaskHandler().isAudioThread());
+ DCHECK(deferredTaskHandler().isAudioThread());
// We shouldn't be calling this method if there's only one connection, since it's less efficient.
- ASSERT(numberOfRenderingConnections() > 1 || handler().internalChannelCountMode() != AudioHandler::Max);
+ DCHECK_GT(static_cast<int>(numberOfRenderingConnections()), 1);
Raymond Toy 2016/07/25 16:56:52 Maybe use DCHECK_GT(numberOfRenderingConnections()
HyungwookLee 2016/07/26 00:42:40 Done.
+ DCHECK_NE(handler().internalChannelCountMode(), AudioHandler::Max);
- ASSERT(summingBus);
+ DCHECK(summingBus);
if (!summingBus)
return;
@@ -184,7 +185,7 @@ void AudioNodeInput::sumAllConnections(AudioBus* summingBus, size_t framesToProc
for (unsigned i = 0; i < numberOfRenderingConnections(); ++i) {
AudioNodeOutput* output = renderingOutput(i);
- ASSERT(output);
+ DCHECK(output);
// Render audio from this output.
AudioBus* connectionBus = output->pull(0, framesToProcess);
@@ -196,7 +197,7 @@ void AudioNodeInput::sumAllConnections(AudioBus* summingBus, size_t framesToProc
AudioBus* AudioNodeInput::pull(AudioBus* inPlaceBus, size_t framesToProcess)
{
- ASSERT(deferredTaskHandler().isAudioThread());
+ DCHECK(deferredTaskHandler().isAudioThread());
// Handle single connection case.
if (numberOfRenderingConnections() == 1 && handler().internalChannelCountMode() == AudioHandler::Max) {

Powered by Google App Engine
This is Rietveld 408576698