Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
index 401894300143d4dc4d616a2114230c1e05f532cb..85ad0ae8a4b0840eef0509dd0e2193023c3590e2 100644
--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
@@ -514,7 +514,7 @@ float PannerHandler::calculateDistanceConeGain(
void PannerHandler::azimuthElevation(double* outAzimuth, double* outElevation)
{
- ASSERT(context()->isAudioThread());
+ DCHECK(context()->isAudioThread());
// Calculate new azimuth and elevation if the panner or the listener changed
// position or orientation in any way.
@@ -535,7 +535,7 @@ void PannerHandler::azimuthElevation(double* outAzimuth, double* outElevation)
float PannerHandler::distanceConeGain()
{
- ASSERT(context()->isAudioThread());
+ DCHECK(context()->isAudioThread());
// Calculate new distance and cone gain if the panner or the listener
// changed position or orientation in any way.
@@ -558,7 +558,7 @@ void PannerHandler::markPannerAsDirty(unsigned dirty)
void PannerHandler::setChannelCount(unsigned long channelCount, ExceptionState& exceptionState)
{
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
BaseAudioContext::AutoLocker locker(context());
// A PannerNode only supports 1 or 2 channels
@@ -583,7 +583,7 @@ void PannerHandler::setChannelCount(unsigned long channelCount, ExceptionState&
void PannerHandler::setChannelCountMode(const String& mode, ExceptionState& exceptionState)
{
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
BaseAudioContext::AutoLocker locker(context());
if (mode == "clamped-max") {

Powered by Google App Engine
This is Rietveld 408576698