Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: third_party/WebKit/Source/modules/webaudio/GainNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/GainNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/GainNode.cpp b/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
index 5921dfb682d13e7731c2ad53d508e40048fc4456..190e61a54f713778a7dcb6c924c56d9dbe1af6c0 100644
--- a/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
@@ -53,7 +53,7 @@ void GainHandler::process(size_t framesToProcess)
// Then we can avoid all of the following:
AudioBus* outputBus = output(0).bus();
- ASSERT(outputBus);
+ DCHECK(outputBus);
if (!isInitialized() || !input(0).isConnected()) {
outputBus->zero();
@@ -62,7 +62,7 @@ void GainHandler::process(size_t framesToProcess)
if (m_gain->hasSampleAccurateValues()) {
// Apply sample-accurate gain scaling for precise envelopes, grain windows, etc.
- ASSERT(framesToProcess <= m_sampleAccurateGainValues.size());
+ DCHECK_LE(framesToProcess, m_sampleAccurateGainValues.size());
if (framesToProcess <= m_sampleAccurateGainValues.size()) {
float* gainValues = m_sampleAccurateGainValues.data();
m_gain->calculateSampleAccurateValues(gainValues, framesToProcess);
@@ -93,11 +93,11 @@ void GainHandler::process(size_t framesToProcess)
// uninitialize and then re-initialize with the new channel count.
void GainHandler::checkNumberOfChannelsForInput(AudioNodeInput* input)
{
- ASSERT(context()->isAudioThread());
+ DCHECK(context()->isAudioThread());
ASSERT(context()->isGraphOwner());
- ASSERT(input);
- ASSERT(input == &this->input(0));
+ DCHECK(input);
+ DCHECK_EQ(input, &this->input(0));
if (input != &this->input(0))
return;

Powered by Google App Engine
This is Rietveld 408576698