Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
index 19620d911463914ad7a7a11ae6a9b5996a8994a5..86c16143e9901a67a269ae2294022c3fa130764d 100644
--- a/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
@@ -115,9 +115,9 @@ void BiquadDSPKernel::updateCoefficients(int numberOfFrames, const float* cutoff
void BiquadDSPKernel::process(const float* source, float* destination, size_t framesToProcess)
{
- ASSERT(source);
- ASSERT(destination);
- ASSERT(getBiquadProcessor());
+ DCHECK(source);
+ DCHECK(destination);
+ DCHECK(getBiquadProcessor());
// Recompute filter coefficients if any of the parameters have changed.
// FIXME: as an optimization, implement a way that a Biquad object can simply copy its internal filter coefficients from another Biquad object.
@@ -138,7 +138,7 @@ void BiquadDSPKernel::process(const float* source, float* destination, size_t fr
void BiquadDSPKernel::getFrequencyResponse(int nFrequencies, const float* frequencyHz, float* magResponse, float* phaseResponse)
{
bool isGood = nFrequencies > 0 && frequencyHz && magResponse && phaseResponse;
- ASSERT(isGood);
+ DCHECK(isGood);
if (!isGood)
return;

Powered by Google App Engine
This is Rietveld 408576698