third_party/WebKit/Source/modules/webaudio/AudioListener.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioListener.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioListener.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp b/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp

index eea7d72d7c566e9e47945147022957923c2acd43..2964ba63bfede3d7988853601881361fb7f2e663 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp

@@ -86,14 +86,14 @@ DEFINE_TRACE(AudioListener)

void AudioListener::addPanner(PannerHandler& panner)

{

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

m_panners.add(&panner);

}

void AudioListener::removePanner(PannerHandler& panner)

{

- ASSERT(isMainThread());

- ASSERT(m_panners.contains(&panner));

+ DCHECK(isMainThread());

+ DCHECK(m_panners.contains(&panner));

m_panners.remove(&panner);

}