third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

index 7fdeda047ec03511ea36f1788e3fcf53795ee387..c4cef6671878b06b39468bc4ff3f0b3e0ab72597 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

@@ -239,8 +239,8 @@ void AudioBuffer::copyFromChannel(DOMFloat32Array* destination, long channelNumb

const float* src = channelData->data();

float* dst = destination->data();

- ASSERT(src);

- ASSERT(dst);

+ DCHECK(src);

+ DCHECK(dst);

memcpy(dst, src + startInChannel, count * sizeof(*src));

}

@@ -287,8 +287,8 @@ void AudioBuffer::copyToChannel(DOMFloat32Array* source, long channelNumber, uns

const float* src = source->data();

float* dst = channelData->data();

- ASSERT(src);

- ASSERT(dst);

+ DCHECK(src);

+ DCHECK(dst);

memcpy(dst + startInChannel, src, count * sizeof(*dst));

}