third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

index f9343a1fc721d3229f530a901fa7a6ff21bfc77c..6a75cf15aa381f40a13aa0ea02e0c168d7b13907 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

@@ -48,7 +48,7 @@ void AudioBasicInspectorHandler::pullInputs(size_t framesToProcess)

AudioNode* AudioBasicInspectorNode::connect(AudioNode* destination, unsigned outputIndex, unsigned inputIndex, ExceptionState& exceptionState)

{

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

BaseAudioContext::AutoLocker locker(context());

@@ -60,7 +60,7 @@ AudioNode* AudioBasicInspectorNode::connect(AudioNode* destination, unsigned out

void AudioBasicInspectorNode::disconnect(unsigned outputIndex, ExceptionState& exceptionState)

{

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

BaseAudioContext::AutoLocker locker(context());

@@ -70,10 +70,10 @@ void AudioBasicInspectorNode::disconnect(unsigned outputIndex, ExceptionState& e

void AudioBasicInspectorHandler::checkNumberOfChannelsForInput(AudioNodeInput* input)

{

- ASSERT(context()->isAudioThread());

+ DCHECK(context()->isAudioThread());

ASSERT(context()->isGraphOwner());

- ASSERT(input == &this->input(0));

+ DCHECK_EQ(input, &this->input(0));

if (input != &this->input(0))

return;