third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp ('k') | third_party/WebKit/Source/modules/webaudio/GainNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

index f13f67ca88fd38dbb1dcab959d4293832989098f..417a55ec582f53f9c2b114332188f61c23ece06e 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

@@ -81,7 +81,7 @@ DynamicsCompressorHandler::~DynamicsCompressorHandler()

void DynamicsCompressorHandler::process(size_t framesToProcess)

{

AudioBus* outputBus = output(0).bus();

- ASSERT(outputBus);

+ DCHECK(outputBus);

float threshold = m_threshold->value();

float knee = m_knee->value();