third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

index f841b05a011302dc632fab2b9612afe28989d204..1f2ffa126676909c18c48615cb4d9de5ac286513 100644

--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

@@ -70,9 +70,9 @@ void WaveShaperDSPKernel::process(const float* source, float* destination, size_

void WaveShaperDSPKernel::processCurve(const float* source, float* destination, size_t framesToProcess)

{

- ASSERT(source);

- ASSERT(destination);

- ASSERT(getWaveShaperProcessor());

+ DCHECK(source);

+ DCHECK(destination);

+ DCHECK(getWaveShaperProcessor());

DOMFloat32Array* curve = getWaveShaperProcessor()->curve();

if (!curve) {

@@ -84,7 +84,7 @@ void WaveShaperDSPKernel::processCurve(const float* source, float* destination,

float* curveData = curve->data();

int curveLength = curve->length();

- ASSERT(curveData);

+ DCHECK(curveData);

if (!curveData || !curveLength) {

memcpy(destination, source, sizeof(float) * framesToProcess);

@@ -126,7 +126,7 @@ void WaveShaperDSPKernel::processCurve(const float* source, float* destination,

void WaveShaperDSPKernel::processCurve2x(const float* source, float* destination, size_t framesToProcess)

{

bool isSafe = framesToProcess == RenderingQuantum;

- ASSERT(isSafe);

+ DCHECK(isSafe);

if (!isSafe)

return;

@@ -143,7 +143,7 @@ void WaveShaperDSPKernel::processCurve2x(const float* source, float* destination

void WaveShaperDSPKernel::processCurve4x(const float* source, float* destination, size_t framesToProcess)

{

bool isSafe = framesToProcess == RenderingQuantum;

- ASSERT(isSafe);

+ DCHECK(isSafe);

if (!isSafe)

return;