third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp

index 47a31c564377323165b606eb549f88df02cc9566..f1f596ff681d8c0efcbdaf5d100c02ee31bcf5f6 100644

--- a/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp

@@ -10,8 +10,8 @@ namespace blink {

void IIRDSPKernel::process(const float* source, float* destination, size_t framesToProcess)

{

- ASSERT(source);

- ASSERT(destination);

+ DCHECK(source);

+ DCHECK(destination);

m_iir.process(source, destination, framesToProcess);

}

@@ -19,7 +19,7 @@ void IIRDSPKernel::process(const float* source, float* destination, size_t frame

void IIRDSPKernel::getFrequencyResponse(int nFrequencies, const float* frequencyHz, float* magResponse, float* phaseResponse)

{

bool isGood = nFrequencies > 0 && frequencyHz && magResponse && phaseResponse;

- ASSERT(isGood);

+ DCHECK(isGood);

if (!isGood)

return;