Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
index 280a5a5827782e408ebd643bfaa6cf48deef0cd8..c0b6a13412e2eec7909c2a947228f2bf8f504dd3 100644
--- a/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
@@ -48,7 +48,7 @@ PassRefPtr<DefaultAudioDestinationHandler> DefaultAudioDestinationHandler::creat
DefaultAudioDestinationHandler::~DefaultAudioDestinationHandler()
{
- ASSERT(!isInitialized());
+ DCHECK(!isInitialized());
}
void DefaultAudioDestinationHandler::dispose()
@@ -59,7 +59,7 @@ void DefaultAudioDestinationHandler::dispose()
void DefaultAudioDestinationHandler::initialize()
{
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
if (isInitialized())
return;
@@ -69,7 +69,7 @@ void DefaultAudioDestinationHandler::initialize()
void DefaultAudioDestinationHandler::uninitialize()
{
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
if (!isInitialized())
return;
@@ -89,18 +89,18 @@ void DefaultAudioDestinationHandler::createDestination()
void DefaultAudioDestinationHandler::startRendering()
{
- ASSERT(isInitialized());
+ DCHECK(isInitialized());
if (isInitialized()) {
- ASSERT(!m_destination->isPlaying());
+ DCHECK(!m_destination->isPlaying());
m_destination->start();
}
}
void DefaultAudioDestinationHandler::stopRendering()
{
- ASSERT(isInitialized());
+ DCHECK(isInitialized());
if (isInitialized()) {
- ASSERT(m_destination->isPlaying());
+ DCHECK(m_destination->isPlaying());
m_destination->stop();
}
}
@@ -116,7 +116,7 @@ void DefaultAudioDestinationHandler::setChannelCount(unsigned long channelCount,
// send to the audio hardware. It can only be set depending on the maximum number of
// channels supported by the hardware.
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
if (!maxChannelCount() || channelCount > maxChannelCount()) {
exceptionState.throwDOMException(

Powered by Google App Engine
This is Rietveld 408576698