Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
index 2ebf22d80ace89a6d8fa801b9e6b17ec8cd1f5c7..343e7e4f91447091c76913627a30c6eb3e90d7a6 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
@@ -595,7 +595,7 @@ void BaseAudioContext::setContextState(AudioContextState newState)
}
if (newState == m_contextState) {
- // ASSERTs above failed; just return.
+ // DCHECKs above failed; just return.
return;
}
@@ -633,7 +633,7 @@ void BaseAudioContext::removeFinishedSourceNodes()
void BaseAudioContext::releaseFinishedSourceNodes()
{
- ASSERT(isGraphOwner());
+ DCHECK(isGraphOwner());
DCHECK(isAudioThread());
bool didRemove = false;
for (AudioHandler* handler : m_finishedSourceHandlers) {
@@ -674,7 +674,7 @@ void BaseAudioContext::releaseActiveSourceNodes()
void BaseAudioContext::handleStoppableSourceNodes()
{
- ASSERT(isGraphOwner());
+ DCHECK(isGraphOwner());
// Find AudioBufferSourceNodes to see if we can stop playing them.
for (AudioNode* node : m_activeSourceNodes) {
@@ -755,7 +755,7 @@ void BaseAudioContext::resolvePromisesForResume()
{
// This runs inside the BaseAudioContext's lock when handling pre-render tasks.
DCHECK(isAudioThread());
- ASSERT(isGraphOwner());
+ DCHECK(isGraphOwner());
// Resolve any pending promises created by resume(). Only do this if we haven't already started
// resolving these promises. This gets called very often and it takes some time to resolve the

Powered by Google App Engine
This is Rietveld 408576698