third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h » ('j') | third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp b/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

index 7bed7e4c1c32410838ec0d9c3a448ea0952ae9f8..84af1dc7513bc532781a4cc888d461c717a39035 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioSummingJunction.cpp

@@ -41,7 +41,7 @@ AudioSummingJunction::~AudioSummingJunction()

void AudioSummingJunction::changedOutputs()

{

- ASSERT(deferredTaskHandler().isGraphOwner());

+ DCHECK(deferredTaskHandler().isGraphOwner());

if (!m_renderingStateNeedUpdating) {

deferredTaskHandler().markSummingJunctionDirty(this);

m_renderingStateNeedUpdating = true;

@@ -50,8 +50,8 @@ void AudioSummingJunction::changedOutputs()

void AudioSummingJunction::updateRenderingState()

{

- ASSERT(deferredTaskHandler().isAudioThread());

- ASSERT(deferredTaskHandler().isGraphOwner());

+ DCHECK(deferredTaskHandler().isAudioThread());

+ DCHECK(deferredTaskHandler().isGraphOwner());

if (m_renderingStateNeedUpdating) {

// Copy from m_outputs to m_renderingOutputs.

m_renderingOutputs.resize(m_outputs.size());