Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2233)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParam.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp b/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
index b92edfcd349c9cf4c4533297a397c00233e07b2c..d3296682ced81a59e57176a759017d8634e1895d 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
@@ -217,7 +217,7 @@ float AudioParamHandler::finalValue()
void AudioParamHandler::calculateSampleAccurateValues(float* values, unsigned numberOfValues)
{
bool isSafe = deferredTaskHandler().isAudioThread() && values && numberOfValues;
- ASSERT(isSafe);
+ DCHECK(isSafe);
if (!isSafe)
return;
@@ -227,7 +227,7 @@ void AudioParamHandler::calculateSampleAccurateValues(float* values, unsigned nu
void AudioParamHandler::calculateFinalValues(float* values, unsigned numberOfValues, bool sampleAccurate)
{
bool isGood = deferredTaskHandler().isAudioThread() && values && numberOfValues;
- ASSERT(isGood);
+ DCHECK(isGood);
if (!isGood)
return;
@@ -256,7 +256,7 @@ void AudioParamHandler::calculateFinalValues(float* values, unsigned numberOfVal
for (unsigned i = 0; i < numberOfRenderingConnections(); ++i) {
AudioNodeOutput* output = renderingOutput(i);
- ASSERT(output);
+ DCHECK(output);
// Render audio from this output.
AudioBus* connectionBus = output->pull(0, AudioHandler::ProcessingSizeInFrames);
@@ -281,7 +281,7 @@ void AudioParamHandler::calculateTimelineValues(float* values, unsigned numberOf
void AudioParamHandler::connect(AudioNodeOutput& output)
{
- ASSERT(deferredTaskHandler().isGraphOwner());
+ DCHECK(deferredTaskHandler().isGraphOwner());
if (m_outputs.contains(&output))
return;
@@ -293,7 +293,7 @@ void AudioParamHandler::connect(AudioNodeOutput& output)
void AudioParamHandler::disconnect(AudioNodeOutput& output)
{
- ASSERT(deferredTaskHandler().isGraphOwner());
+ DCHECK(deferredTaskHandler().isGraphOwner());
if (m_outputs.contains(&output)) {
m_outputs.remove(&output);

Powered by Google App Engine
This is Rietveld 408576698