Replace ASSERT with DCHECK in WebAudio

third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 131 matching lines @@
 DEFINE_TRACE(OfflineAudioContext)
 {
     visitor->trace(m_renderTarget);
     visitor->trace(m_completeResolver);
     visitor->trace(m_scheduledSuspends);
     BaseAudioContext::trace(visitor);
 }
 
 ScriptPromise OfflineAudioContext::startOfflineRendering(ScriptState* scriptState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     // Calling close() on an OfflineAudioContext is not supported/allowed,
     // but it might well have been stopped by its execution context.
     //
     // See: crbug.com/435867
     if (isContextClosed()) {
         return ScriptPromise::rejectWithDOMException(
             scriptState,
             DOMException::create(
                 InvalidStateError,
@@ skipping 11 matching lines @@
 
     // Can't call startRendering more than once.  Return a rejected promise now.
     if (m_isRenderingStarted) {
         return ScriptPromise::rejectWithDOMException(
             scriptState,
             DOMException::create(
                 InvalidStateError,
                 "cannot call startRendering more than once"));
     }
 
-    ASSERT(!m_isRenderingStarted);
+    DCHECK(!m_isRenderingStarted);
 
     m_completeResolver = ScriptPromiseResolver::create(scriptState);
 
     // Start rendering and return the promise.
     m_isRenderingStarted = true;
     setContextState(Running);
     destinationHandler().startRendering();
 
     return m_completeResolver->promise();
 }
@@ skipping 11 matching lines @@
 {
     // This CANNOT be called on OfflineAudioContext; this is only to implement
     // the pure virtual interface from BaseAudioContext.
     RELEASE_NOTREACHED();
 
     return ScriptPromise();
 }
 
 ScriptPromise OfflineAudioContext::suspendContext(ScriptState* scriptState, double when)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
     // The render thread does not exist; reject the promise.
     if (!destinationHandler().offlineRenderThread()) {
         resolver->reject(DOMException::create(InvalidStateError,
             "the rendering is already finished"));
         return promise;
     }
@@ skipping 46 matching lines @@
         return promise;
     }
 
     m_scheduledSuspends.add(frame, resolver);
 
     return promise;
 }
 
 ScriptPromise OfflineAudioContext::resumeContext(ScriptState* scriptState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
     // If the rendering has not started, reject the promise.
     if (!m_isRenderingStarted) {
         resolver->reject(DOMException::create(InvalidStateError,
             "cannot resume an offline context that has not started"));
         return promise;
     }
 
     // If the context is in a closed state, reject the promise.
     if (contextState() == AudioContextState::Closed) {
         resolver->reject(DOMException::create(InvalidStateError,
             "cannot resume a closed offline context"));
         return promise;
     }
 
     // If the context is already running, resolve the promise without altering
     // the current state or starting the rendering loop.
     if (contextState() == AudioContextState::Running) {
         resolver->resolve();
         return promise;
     }
 
-    ASSERT(contextState() == AudioContextState::Suspended);
+    DCHECK_EQ(contextState(), AudioContextState::Suspended);
 
     // If the context is suspended, resume rendering by setting the state to
     // "Running". and calling startRendering(). Note that resuming is possible
     // only after the rendering started.
     setContextState(Running);
     destinationHandler().startRendering();
 
     // Resolve the promise immediately.
     resolver->resolve();
 
     return promise;
 }
 
 void OfflineAudioContext::fireCompletionEvent()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     // We set the state to closed here so that the oncomplete event handler sees
     // that the context has been closed.
     setContextState(Closed);
 
     AudioBuffer* renderedBuffer = renderTarget();
 
-    ASSERT(renderedBuffer);
+    DCHECK(renderedBuffer);
     if (!renderedBuffer)
         return;
 
     // Avoid firing the event if the document has already gone away.
     if (getExecutionContext()) {
         // Call the offline rendering completion event listener and resolve the
         // promise too.
         dispatchEvent(OfflineAudioCompletionEvent::create(renderedBuffer));
         m_completeResolver->resolve(renderedBuffer);
     } else {
         // The resolver should be rejected when the execution context is gone.
         m_completeResolver->reject(DOMException::create(InvalidStateError,
             "the execution context does not exist"));
     }
 }
 
 bool OfflineAudioContext::handlePreOfflineRenderTasks()
 {
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
 
     // OfflineGraphAutoLocker here locks the audio graph for this scope. Note
     // that this locker does not use tryLock() inside because the timing of
     // suspension MUST NOT be delayed.
     OfflineGraphAutoLocker locker(this);
 
     // Update the dirty state of the listener.
     listener()->updateState();
 
     deferredTaskHandler().handleDeferredTasks();
     handleStoppableSourceNodes();
 
     return shouldSuspend();
 }
 
 void OfflineAudioContext::handlePostOfflineRenderTasks()
 {
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
 
     // OfflineGraphAutoLocker here locks the audio graph for the same reason
     // above in |handlePreOfflineRenderTasks|.
     OfflineGraphAutoLocker locker(this);
 
     deferredTaskHandler().breakConnections();
     releaseFinishedSourceNodes();
     deferredTaskHandler().handleDeferredTasks();
     deferredTaskHandler().requestToDeleteHandlersOnMainThread();
 }
 
 
 OfflineAudioDestinationHandler& OfflineAudioContext::destinationHandler()
 {
     return static_cast<OfflineAudioDestinationHandler&>(destination()->audioDestinationHandler());
 }
 
 void OfflineAudioContext::resolveSuspendOnMainThread(size_t frame)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     // Suspend the context first. This will fire onstatechange event.
     setContextState(Suspended);
 
     // Wait until the suspend map is available for the removal.
     AutoLocker locker(this);
 
     // If the context is going away, m_scheduledSuspends could have had all its entries removed.
     // Check for that here.
     if (m_scheduledSuspends.size()) {
         // |frame| must exist in the map.
         DCHECK(m_scheduledSuspends.contains(frame));
 
         SuspendMap::iterator it = m_scheduledSuspends.find(frame);
         it->value->resolve();
 
         m_scheduledSuspends.remove(it);
     }
 }
 
 void OfflineAudioContext::rejectPendingResolvers()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     // Wait until the suspend map is available for removal.
     AutoLocker locker(this);
 
     // Offline context is going away so reject any promises that are still pending.
 
     for (auto& pendingSuspendResolver : m_scheduledSuspends) {
         pendingSuspendResolver.value->reject(DOMException::create(
             InvalidStateError, "Audio context is going away"));
     }
 
     m_scheduledSuspends.clear();
-    ASSERT(m_resumeResolvers.size() == 0);
+    DCHECK_EQ(static_cast<int>(m_resumeResolvers.size()), 0);

[Raymond Toy, 2016/07/25 16:56:53]

DCHECK_EQ(..., 0u)

[HyungwookLee, 2016/07/26 00:42:40]

Done.

 
     rejectPendingDecodeAudioDataResolvers();
 }
 
 bool OfflineAudioContext::shouldSuspend()
 {
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
 
     // Note that the GraphLock is required before this check. Since this needs
     // to run on the audio thread, OfflineGraphAutoLocker must be used.
     if (m_scheduledSuspends.contains(currentSampleFrame()))
         return true;
 
     return false;
 }
 
 } // namespace blink