Replace ASSERT with DCHECK in WebAudio

third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 23 matching lines @@
 
 AudioDestinationHandler::AudioDestinationHandler(AudioNode& node, float sampleRate)
     : AudioHandler(NodeTypeDestination, node, sampleRate)
     , m_currentSampleFrame(0)
 {
     addInput();
 }
 
 AudioDestinationHandler::~AudioDestinationHandler()
 {
-    ASSERT(!isInitialized());
+    DCHECK(!isInitialized());
 }
 
 void AudioDestinationHandler::render(AudioBus* sourceBus, AudioBus* destinationBus, size_t numberOfFrames)
 {
     // We don't want denormals slowing down any of the audio processing
     // since they can very seriously hurt performance.
     // This will take care of all AudioNodes because they all process within this scope.
     DenormalDisabler denormalDisabler;
 
     // Need to check if the context actually alive. Otherwise the subsequent
     // steps will fail. If the context is not alive somehow, return immediately
     // and do nothing.
     //
     // TODO(hongchan): because the context can go away while rendering, so this
     // check cannot guarantee the safe execution of the following steps.
-    ASSERT(context());
+    DCHECK(context());
     if (!context())
         return;
 
     context()->deferredTaskHandler().setAudioThreadToCurrentThread();
 
     // If the destination node is not initialized, pass the silence to the final
     // audio destination (one step before the FIFO). This check is for the case
     // where the destination is in the middle of tearing down process.
     if (!isInitialized()) {
         destinationBus->zero();
         return;
     }
 
     // Let the context take care of any business at the start of each render quantum.
     context()->handlePreRenderTasks();
 
     // Prepare the local audio input provider for this render quantum.
     if (sourceBus)
         m_localAudioInputProvider.set(sourceBus);
 
-    ASSERT(numberOfInputs() >= 1);
+    DCHECK_GE(static_cast<int>(numberOfInputs()), 1);

[Raymond Toy, 2016/07/25 16:56:52]

I think this is better written as

DCHECK_GE(numberOfInputs, 1u)

[HyungwookLee, 2016/07/26 00:42:40]

Done.

     if (numberOfInputs() < 1) {
         destinationBus->zero();
         return;
     }
     // This will cause the node(s) connected to us to process, which in turn will pull on their input(s),
     // all the way backwards through the rendering graph.
     AudioBus* renderedBus = input(0).pull(destinationBus, numberOfFrames);
 
     if (!renderedBus) {
         destinationBus->zero();
@@ skipping 25 matching lines @@
     return static_cast<AudioDestinationHandler&>(handler());
 }
 
 unsigned long AudioDestinationNode::maxChannelCount() const
 {
     return audioDestinationHandler().maxChannelCount();
 }
 
 } // namespace blink