Replace ASSERT with DCHECK in WebAudio

third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 67 matching lines @@
         // since the node may be deleted.
         return;
     }
 
     ASSERT_NOT_REACHED();
 }
 
 void AudioNodeInput::disable(AudioNodeOutput& output)
 {
     ASSERT(deferredTaskHandler().isGraphOwner());
-    ASSERT(m_outputs.contains(&output));
+    DCHECK(m_outputs.contains(&output));
 
     m_disabledOutputs.add(&output);
     m_outputs.remove(&output);
     changedOutputs();
 
     // Propagate disabled state to outputs.
     handler().disableOutputsIfNecessary();
 }
 
 void AudioNodeInput::enable(AudioNodeOutput& output)
 {
     ASSERT(deferredTaskHandler().isGraphOwner());
-    ASSERT(m_disabledOutputs.contains(&output));
+    DCHECK(m_disabledOutputs.contains(&output));
 
     // Move output from disabled list to active list.
     m_outputs.add(&output);
     m_disabledOutputs.remove(&output);
     changedOutputs();
 
     // Propagate enabled state to outputs.
     handler().enableOutputsIfNecessary();
 }
 
 void AudioNodeInput::didUpdate()
 {
     handler().checkNumberOfChannelsForInput(this);
 }
 
 void AudioNodeInput::updateInternalBus()
 {
-    ASSERT(deferredTaskHandler().isAudioThread());
+    DCHECK(deferredTaskHandler().isAudioThread());
     ASSERT(deferredTaskHandler().isGraphOwner());
 
     unsigned numberOfInputChannels = numberOfChannels();
 
     if (numberOfInputChannels == m_internalSummingBus->numberOfChannels())
         return;
 
     m_internalSummingBus = AudioBus::create(numberOfInputChannels, AudioHandler::ProcessingSizeInFrames);
 }
 
@@ skipping 13 matching lines @@
     }
 
     if (mode == AudioHandler::ClampedMax)
         maxChannels = std::min(maxChannels, static_cast<unsigned>(handler().channelCount()));
 
     return maxChannels;
 }
 
 AudioBus* AudioNodeInput::bus()
 {
-    ASSERT(deferredTaskHandler().isAudioThread());
+    DCHECK(deferredTaskHandler().isAudioThread());
 
     // Handle single connection specially to allow for in-place processing.
     if (numberOfRenderingConnections() == 1 && handler().internalChannelCountMode() == AudioHandler::Max)
         return renderingOutput(0)->bus();
 
     // Multiple connections case or complex ChannelCountMode (or no connections).
     return internalSummingBus();
 }
 
 AudioBus* AudioNodeInput::internalSummingBus()
 {
-    ASSERT(deferredTaskHandler().isAudioThread());
+    DCHECK(deferredTaskHandler().isAudioThread());
 
     return m_internalSummingBus.get();
 }
 
 void AudioNodeInput::sumAllConnections(AudioBus* summingBus, size_t framesToProcess)
 {
-    ASSERT(deferredTaskHandler().isAudioThread());
+    DCHECK(deferredTaskHandler().isAudioThread());
 
     // We shouldn't be calling this method if there's only one connection, since it's less efficient.
-    ASSERT(numberOfRenderingConnections() > 1 || handler().internalChannelCountMode() != AudioHandler::Max);
+    DCHECK(numberOfRenderingConnections() > 1 || handler().internalChannelCountMode() != AudioHandler::Max);

[Raymond Toy, 2016/07/22 14:59:26]

Since we're rewriting these anyway, I think I'd prefer

DCHECK_GT(numberOfRenderingConnections(), 1);
DCHECK_NE(handler().internalChannelCountMode(), AudioHandler::Max);

This is way more informative since you can tell which of the conditions is
actually failing.

I think there's at least one more place that does ASSERT(<multiple conditions>).
I think they should be split out.

[HyungwookLee, 2016/07/25 00:24:44]

Done.

 
-    ASSERT(summingBus);
+    DCHECK(summingBus);
     if (!summingBus)
         return;
 
     summingBus->zero();
 
     AudioBus::ChannelInterpretation interpretation = handler().internalChannelInterpretation();
 
     for (unsigned i = 0; i < numberOfRenderingConnections(); ++i) {
         AudioNodeOutput* output = renderingOutput(i);
-        ASSERT(output);
+        DCHECK(output);
 
         // Render audio from this output.
         AudioBus* connectionBus = output->pull(0, framesToProcess);
 
         // Sum, with unity-gain.
         summingBus->sumFrom(*connectionBus, interpretation);
     }
 }
 
 AudioBus* AudioNodeInput::pull(AudioBus* inPlaceBus, size_t framesToProcess)
 {
-    ASSERT(deferredTaskHandler().isAudioThread());
+    DCHECK(deferredTaskHandler().isAudioThread());
 
     // Handle single connection case.
     if (numberOfRenderingConnections() == 1 && handler().internalChannelCountMode() == AudioHandler::Max) {
         // The output will optimize processing using inPlaceBus if it's able.
         AudioNodeOutput* output = this->renderingOutput(0);
         return output->pull(inPlaceBus, framesToProcess);
     }
 
     AudioBus* internalSummingBus = this->internalSummingBus();
 
     if (!numberOfRenderingConnections()) {
         // At least, generate silence if we're not connected to anything.
         // FIXME: if we wanted to get fancy, we could propagate a 'silent hint' here to optimize the downstream graph processing.
         internalSummingBus->zero();
         return internalSummingBus;
     }
 
     // Handle multiple connections case.
     sumAllConnections(internalSummingBus, framesToProcess);
 
     return internalSummingBus;
 }
 
 } // namespace blink