Replace ASSERT with DCHECK in WebAudio

third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 133 matching lines @@
     // in order to record metrics, re-using the HTMLMediaElement setting is
     // probably the simplest solution.
     if (document->settings() && document->settings()->mediaPlaybackRequiresUserGesture())
         m_userGestureRequired = true;
 }
 
 AbstractAudioContext::~AbstractAudioContext()
 {
     deferredTaskHandler().contextWillBeDestroyed();
     // AudioNodes keep a reference to their context, so there should be no way to be in the destructor if there are still AudioNodes around.
-    ASSERT(!isDestinationInitialized());
-    ASSERT(!m_activeSourceNodes.size());
-    ASSERT(!m_finishedSourceHandlers.size());
-    ASSERT(!m_isResolvingResumePromises);
-    ASSERT(!m_resumeResolvers.size());
+    DCHECK(!isDestinationInitialized());
+    DCHECK(!m_activeSourceNodes.size());
+    DCHECK(!m_finishedSourceHandlers.size());
+    DCHECK(!m_isResolvingResumePromises);
+    DCHECK(!m_resumeResolvers.size());
 }
 
 void AbstractAudioContext::initialize()
 {
     if (isDestinationInitialized())
         return;
 
     FFTFrame::initialize();
 
     if (m_destinationNode) {
         m_destinationNode->handler().initialize();
         // The AudioParams in the listener need access to the destination node, so only create the
         // listener if the destination node exists.
         m_listener = AudioListener::create(*this);
     }
 }
 
 void AbstractAudioContext::clear()
 {
     m_destinationNode.clear();
     // The audio rendering thread is dead.  Nobody will schedule AudioHandler
     // deletion.  Let's do it ourselves.
     deferredTaskHandler().clearHandlersToBeDeleted();
     m_isCleared = true;
 }
 
 void AbstractAudioContext::uninitialize()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     if (!isDestinationInitialized())
         return;
 
     // This stops the audio thread and all audio rendering.
     if (m_destinationNode)
         m_destinationNode->handler().uninitialize();
 
     // Get rid of the sources which may still be playing.
     releaseActiveSourceNodes();
 
     // Reject any pending resolvers before we go away.
     rejectPendingResolvers();
     didClose();
 
-    ASSERT(m_listener);
+    DCHECK(m_listener);
     m_listener->waitForHRTFDatabaseLoaderThreadCompletion();
 
     clear();
 }
 
 void AbstractAudioContext::stop()
 {
     uninitialize();
 }
 
 bool AbstractAudioContext::hasPendingActivity() const
 {
     // There's no pending activity if the audio context has been cleared.
     return !m_isCleared;
 }
 
 AudioDestinationNode* AbstractAudioContext::destination() const
 {
     // Cannot be called from the audio thread because this method touches objects managed by Oilpan,
     // and the audio thread is not managed by Oilpan.
-    ASSERT(!isAudioThread());
+    DCHECK(!isAudioThread());
     return m_destinationNode;
 }
 
 void AbstractAudioContext::throwExceptionForClosedState(ExceptionState& exceptionState)
 {
     exceptionState.throwDOMException(InvalidStateError, "AudioContext has been closed.");
 }
 
 AudioBuffer* AbstractAudioContext::createBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState& exceptionState)
 {
@@ skipping 38 matching lines @@
             float ratio = 100 * sampleRate / this->sampleRate();
             audioBufferSampleRateRatioHistogram.count(static_cast<int>(0.5 + ratio));
         }
     }
 
     return buffer;
 }
 
 ScriptPromise AbstractAudioContext::decodeAudioData(ScriptState* scriptState, DOMArrayBuffer* audioData, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
-    ASSERT(audioData);
+    DCHECK(isMainThread());
+    DCHECK(audioData);
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
     float rate = isContextClosed() ? closedContextSampleRate() : sampleRate();
 
-    ASSERT(rate > 0);
+    DCHECK_GT(rate, 0);
 
     m_decodeAudioResolvers.add(resolver);
     m_audioDecoder.decodeAsync(audioData, rate, successCallback, errorCallback, resolver, this);
 
     return promise;
 }
 
 void AbstractAudioContext::handleDecodeAudioData(AudioBuffer* audioBuffer, ScriptPromiseResolver* resolver, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     if (audioBuffer) {
         // Resolve promise successfully and run the success callback
         resolver->resolve(audioBuffer);
         if (successCallback)
             successCallback->handleEvent(audioBuffer);
     } else {
         // Reject the promise and run the error callback
         DOMException* error = DOMException::create(EncodingError, "Unable to decode audio data");
         resolver->reject(error);
         if (errorCallback)
             errorCallback->handleEvent(error);
     }
 
     // We've resolved the promise.  Remove it now.
-    ASSERT(m_decodeAudioResolvers.contains(resolver));
+    DCHECK(m_decodeAudioResolvers.contains(resolver));
     m_decodeAudioResolvers.remove(resolver);
 }
 
 AudioBufferSourceNode* AbstractAudioContext::createBufferSource(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     AudioBufferSourceNode* node = AudioBufferSourceNode::create(*this, exceptionState);
 
     // Do not add a reference to this source node now. The reference will be added when start() is
     // called.
 
     return node;
 }
 
 MediaElementAudioSourceNode* AbstractAudioContext::createMediaElementSource(HTMLMediaElement* mediaElement, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return MediaElementAudioSourceNode::create(*this, *mediaElement, exceptionState);
 }
 
 MediaStreamAudioSourceNode* AbstractAudioContext::createMediaStreamSource(MediaStream* mediaStream, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return MediaStreamAudioSourceNode::create(*this, *mediaStream, exceptionState);
 }
 
 MediaStreamAudioDestinationNode* AbstractAudioContext::createMediaStreamDestination(ExceptionState& exceptionState)
 {
     DCHECK(isMainThread());
 
     // Set number of output channels to stereo by default.
     return MediaStreamAudioDestinationNode::create(*this, 2, exceptionState);
@@ skipping 15 matching lines @@
 
 ScriptProcessorNode* AbstractAudioContext::createScriptProcessor(size_t bufferSize, size_t numberOfInputChannels, ExceptionState& exceptionState)
 {
     DCHECK(isMainThread());
 
     return ScriptProcessorNode::create(*this, bufferSize, numberOfInputChannels, exceptionState);
 }
 
 ScriptProcessorNode* AbstractAudioContext::createScriptProcessor(size_t bufferSize, size_t numberOfInputChannels, size_t numberOfOutputChannels, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return ScriptProcessorNode::create(
         *this,
         bufferSize,
         numberOfInputChannels,
         numberOfOutputChannels,
         exceptionState);
 }
 
 StereoPannerNode* AbstractAudioContext::createStereoPanner(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return StereoPannerNode::create(*this, exceptionState);
 }
 
 BiquadFilterNode* AbstractAudioContext::createBiquadFilter(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return BiquadFilterNode::create(*this, exceptionState);
 }
 
 WaveShaperNode* AbstractAudioContext::createWaveShaper(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return WaveShaperNode::create(*this, exceptionState);
 }
 
 PannerNode* AbstractAudioContext::createPanner(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return PannerNode::create(*this, exceptionState);
 }
 
 ConvolverNode* AbstractAudioContext::createConvolver(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return ConvolverNode::create(*this, exceptionState);
 }
 
 DynamicsCompressorNode* AbstractAudioContext::createDynamicsCompressor(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return DynamicsCompressorNode::create(*this, exceptionState);
 }
 
 AnalyserNode* AbstractAudioContext::createAnalyser(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return AnalyserNode::create(*this, exceptionState);
 }
 
 GainNode* AbstractAudioContext::createGain(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return GainNode::create(*this, exceptionState);
 }
 
 DelayNode* AbstractAudioContext::createDelay(ExceptionState& exceptionState)
 {
     DCHECK(isMainThread());
 
     return DelayNode::create(*this, exceptionState);
 }
 
 DelayNode* AbstractAudioContext::createDelay(double maxDelayTime, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return DelayNode::create(*this, maxDelayTime, exceptionState);
 }
 
 ChannelSplitterNode* AbstractAudioContext::createChannelSplitter(ExceptionState& exceptionState)
 {
     DCHECK(isMainThread());
 
     return ChannelSplitterNode::create(*this, exceptionState);
 }
 
 ChannelSplitterNode* AbstractAudioContext::createChannelSplitter(size_t numberOfOutputs, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return ChannelSplitterNode::create(*this, numberOfOutputs, exceptionState);
 }
 
 ChannelMergerNode* AbstractAudioContext::createChannelMerger(ExceptionState& exceptionState)
 {
     DCHECK(isMainThread());
 
     return ChannelMergerNode::create(*this, exceptionState);
 }
 
 ChannelMergerNode* AbstractAudioContext::createChannelMerger(size_t numberOfInputs, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return ChannelMergerNode::create(*this, numberOfInputs, exceptionState);
 }
 
 OscillatorNode* AbstractAudioContext::createOscillator(ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return OscillatorNode::create(*this, exceptionState);
 }
 
 PeriodicWave* AbstractAudioContext::createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, ExceptionState& exceptionState)
 {
     DCHECK(isMainThread());
 
     return PeriodicWave::create(*this, real, imag, false, exceptionState);
 }
 
 PeriodicWave* AbstractAudioContext::createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, const PeriodicWaveConstraints& options, ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     bool disable = options.hasDisableNormalization() ? options.disableNormalization() : false;
 
     return PeriodicWave::create(*this, real, imag, disable, exceptionState);
 }
 
 IIRFilterNode* AbstractAudioContext::createIIRFilter(Vector<double> feedforwardCoef, Vector<double> feedbackCoef,  ExceptionState& exceptionState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     return IIRFilterNode::create(*this, feedforwardCoef, feedbackCoef, exceptionState);
 }
 
 PeriodicWave* AbstractAudioContext::periodicWave(int type)
 {
     switch (type) {
     case OscillatorHandler::SINE:
         // Initialize the table if necessary
         if (!m_periodicWaveSine)
@@ skipping 49 matching lines @@
         return "running";
     case Closed:
         return "closed";
     }
     ASSERT_NOT_REACHED();
     return "";
 }
 
 void AbstractAudioContext::setContextState(AudioContextState newState)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     // Validate the transitions.  The valid transitions are Suspended->Running, Running->Suspended,
     // and anything->Closed.
     switch (newState) {
     case Suspended:
-        ASSERT(m_contextState == Running);
+        DCHECK(m_contextState == Running);

[hongchan, 2016/07/20 16:11:19]

Perhaps use DCHECK_EQ?

[HyungwookLee, 2016/07/22 03:30:33]

Done.

         break;
     case Running:
-        ASSERT(m_contextState == Suspended);
+        DCHECK(m_contextState == Suspended);

[hongchan, 2016/07/20 16:11:19]

ditto.

[HyungwookLee, 2016/07/22 03:30:33]

Done.

         break;
     case Closed:
-        ASSERT(m_contextState != Closed);
+        DCHECK(m_contextState != Closed);

[hongchan, 2016/07/20 16:11:19]

DCHECK_NE here?

[HyungwookLee, 2016/07/22 03:30:33]

Done.

         break;
     }
 
     if (newState == m_contextState) {
         // ASSERTs above failed; just return.

[hongchan, 2016/07/20 16:11:19]

Change the comment accordingly.

[HyungwookLee, 2016/07/22 03:30:33]

Done.

         return;
     }
 
     m_contextState = newState;
 
     // Notify context that state changed
     if (getExecutionContext())
         getExecutionContext()->postTask(BLINK_FROM_HERE, createSameThreadTask(&AbstractAudioContext::notifyStateChange, wrapPersistent(this)));
 }
 
 void AbstractAudioContext::notifyStateChange()
 {
     dispatchEvent(Event::create(EventTypeNames::statechange));
 }
 
 void AbstractAudioContext::notifySourceNodeFinishedProcessing(AudioHandler* handler)
 {
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
     m_finishedSourceHandlers.append(handler);
 }
 
 void AbstractAudioContext::removeFinishedSourceNodes()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
     AutoLocker locker(this);
     // Quadratic worst case, but sizes of both vectors are considered
     // manageable, especially |m_finishedSourceNodes| is likely to be short.
     for (AudioNode* node : m_finishedSourceNodes) {
         size_t i = m_activeSourceNodes.find(node);
         if (i != kNotFound)
             m_activeSourceNodes.remove(i);
     }
     m_finishedSourceNodes.clear();
 }
 
 void AbstractAudioContext::releaseFinishedSourceNodes()
 {
     ASSERT(isGraphOwner());
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
     bool didRemove = false;
     for (AudioHandler* handler : m_finishedSourceHandlers) {
         for (AudioNode* node : m_activeSourceNodes) {
             if (m_finishedSourceNodes.contains(node))
                 continue;
             if (handler == &node->handler()) {
                 handler->breakConnection();
                 m_finishedSourceNodes.add(node);
                 didRemove = true;
                 break;
             }
         }
     }
     if (didRemove)
         Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind(&AbstractAudioContext::removeFinishedSourceNodes, wrapCrossThreadPersistent(this)));
 
     m_finishedSourceHandlers.clear();
 }
 
 void AbstractAudioContext::notifySourceNodeStartedProcessing(AudioNode* node)
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
     AutoLocker locker(this);
 
     m_activeSourceNodes.append(node);
     node->handler().makeConnection();
 }
 
 void AbstractAudioContext::releaseActiveSourceNodes()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
     for (auto& sourceNode : m_activeSourceNodes)
         sourceNode->handler().breakConnection();
 
     m_activeSourceNodes.clear();
 }
 
 void AbstractAudioContext::handleStoppableSourceNodes()
 {
     ASSERT(isGraphOwner());
 
     // Find AudioBufferSourceNodes to see if we can stop playing them.
     for (AudioNode* node : m_activeSourceNodes) {
         // If the AudioNode has been marked as finished and released by
         // the audio thread, but not yet removed by the main thread
         // (see releaseActiveSourceNodes() above), |node| must not be
         // touched as its handler may have been released already.
         if (m_finishedSourceNodes.contains(node))
             continue;
         if (node->handler().getNodeType() == AudioHandler::NodeTypeAudioBufferSource) {
             AudioBufferSourceNode* sourceNode = static_cast<AudioBufferSourceNode*>(node);
             sourceNode->audioBufferSourceHandler().handleStoppableSourceNode();
         }
     }
 }
 
 void AbstractAudioContext::handlePreRenderTasks()
 {
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
 
     // At the beginning of every render quantum, try to update the internal rendering graph state (from main thread changes).
     // It's OK if the tryLock() fails, we'll just take slightly longer to pick up the changes.
     if (tryLock()) {
         deferredTaskHandler().handleDeferredTasks();
 
         resolvePromisesForResume();
 
         // Check to see if source nodes can be stopped because the end time has passed.
         handleStoppableSourceNodes();
 
         // Update the dirty state of the listener.
         listener()->updateState();
 
         unlock();
     }
 }
 
 void AbstractAudioContext::handlePostRenderTasks()
 {
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
 
     // Must use a tryLock() here too.  Don't worry, the lock will very rarely be contended and this method is called frequently.
     // The worst that can happen is that there will be some nodes which will take slightly longer than usual to be deleted or removed
     // from the render graph (in which case they'll render silence).
     if (tryLock()) {
         // Take care of AudioNode tasks where the tryLock() failed previously.
         deferredTaskHandler().breakConnections();
 
         // Dynamically clean up nodes which are no longer needed.
         releaseFinishedSourceNodes();
 
         deferredTaskHandler().handleDeferredTasks();
         deferredTaskHandler().requestToDeleteHandlersOnMainThread();
 
         unlock();
     }
 }
 
 void AbstractAudioContext::resolvePromisesForResumeOnMainThread()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
     AutoLocker locker(this);
 
     for (auto& resolver : m_resumeResolvers) {
         if (m_contextState == Closed) {
             resolver->reject(
                 DOMException::create(InvalidStateError, "Cannot resume a context that has been closed"));
         } else {
             resolver->resolve();
         }
     }
 
     m_resumeResolvers.clear();
     m_isResolvingResumePromises = false;
 }
 
 void AbstractAudioContext::resolvePromisesForResume()
 {
     // This runs inside the AbstractAudioContext's lock when handling pre-render tasks.
-    ASSERT(isAudioThread());
+    DCHECK(isAudioThread());
     ASSERT(isGraphOwner());
 
     // Resolve any pending promises created by resume(). Only do this if we haven't already started
     // resolving these promises. This gets called very often and it takes some time to resolve the
     // promises in the main thread.
     if (!m_isResolvingResumePromises && m_resumeResolvers.size() > 0) {
         m_isResolvingResumePromises = true;
         Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, crossThreadBind(&AbstractAudioContext::resolvePromisesForResumeOnMainThread, wrapCrossThreadPersistent(this)));
     }
 }
 
 void AbstractAudioContext::rejectPendingDecodeAudioDataResolvers()
 {
     // Now reject any pending decodeAudioData resolvers
     for (auto& resolver : m_decodeAudioResolvers)
         resolver->reject(DOMException::create(InvalidStateError, "Audio context is going away"));
     m_decodeAudioResolvers.clear();
 }
 
 void AbstractAudioContext::rejectPendingResolvers()
 {
-    ASSERT(isMainThread());
+    DCHECK(isMainThread());
 
     // Audio context is closing down so reject any resume promises that are still pending.
 
     for (auto& resolver : m_resumeResolvers) {
         resolver->reject(DOMException::create(InvalidStateError, "Audio context is going away"));
     }
     m_resumeResolvers.clear();
     m_isResolvingResumePromises = false;
 
     rejectPendingDecodeAudioDataResolvers();
 }
 
 const AtomicString& AbstractAudioContext::interfaceName() const
 {
     return EventTargetNames::AudioContext;
 }
 
 ExecutionContext* AbstractAudioContext::getExecutionContext() const
 {
     return ActiveDOMObject::getExecutionContext();
 }
 
 void AbstractAudioContext::startRendering()
 {
     // This is called for both online and offline contexts.
-    ASSERT(isMainThread());
-    ASSERT(m_destinationNode);
+    DCHECK(isMainThread());
+    DCHECK(m_destinationNode);
 
     recordUserGestureState();
 
     if (m_contextState == Suspended) {
         destination()->audioDestinationHandler().startRendering();
         setContextState(Running);
     }
 }
 
 DEFINE_TRACE(AbstractAudioContext)
@@ skipping 14 matching lines @@
 
 SecurityOrigin* AbstractAudioContext::getSecurityOrigin() const
 {
     if (getExecutionContext())
         return getExecutionContext()->getSecurityOrigin();
 
     return nullptr;
 }
 
 } // namespace blink