Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2159373004: [turbofan] Properly handle bit->tagged representation changes. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly handle bit->tagged representation changes. Look at the output type instead of the output representation, when converting to tagged representation. R=jarin@chromium.org Committed: https://crrev.com/1f3c8dc71fefaf17062f7c78073bb31555d48738 Cr-Commit-Position: refs/heads/master@{#37891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/compiler/representation-change.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-20 08:10:27 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-20 08:11:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159373004/1
4 years, 5 months ago (2016-07-20 08:11:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 08:48:55 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 08:52:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f3c8dc71fefaf17062f7c78073bb31555d48738
Cr-Commit-Position: refs/heads/master@{#37891}

Powered by Google App Engine
This is Rietveld 408576698