third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2159373003: Cursor should respect text align in contenteditable with pseudo element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2159373003: Cursor should respect text align in contenteditable with pseudo element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added testcase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html ('K') | « third_party/WebKit/LayoutTests/editing/selection/caret-in-empty-div-with-pseudo-content.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index bc34b9db1025b2770f6ea5057c156dcd55f505d4..a2739a7ffa550b14669a151d4ad11174953dc74e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1606,7 +1606,7 @@ bool LayoutBlock::hasDragCaret() const

LayoutRect LayoutBlock::localCaretRect(InlineBox* inlineBox, int caretOffset, LayoutUnit* extraWidthToEndOfLine)

{

// Do the normal calculation in most cases.

- if (firstChild() || isInlineBoxWrapperActuallyChild())

+ if ((firstChild() && !firstChild()->isPseudoElement()) || isInlineBoxWrapperActuallyChild())

return LayoutBox::localCaretRect(inlineBox, caretOffset, extraWidthToEndOfLine);

LayoutRect caretRect = localCaretRectForEmptyElement(size().width(), textIndentOffset());