Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/android/cookies/cookies_fetcher.cc

Issue 2159373002: net: make CanonicalCookie's constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: domain Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/net/cookies/cookie_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/cookies/cookies_fetcher.cc
diff --git a/chrome/browser/android/cookies/cookies_fetcher.cc b/chrome/browser/android/cookies/cookies_fetcher.cc
index e21dabc5f2e61900e2e200d51983ca4fb93aee10..b795c441488fd2295c1554f278550f3492177396 100644
--- a/chrome/browser/android/cookies/cookies_fetcher.cc
+++ b/chrome/browser/android/cookies/cookies_fetcher.cc
@@ -157,16 +157,17 @@ static void RestoreCookies(JNIEnv* env,
scoped_refptr<net::URLRequestContextGetter> getter(
profile->GetRequestContext());
- net::CanonicalCookie cookie(
- GURL(), base::android::ConvertJavaStringToUTF8(env, name),
+ net::CanonicalCookie cookie(*net::CanonicalCookie::Create(
+ base::android::ConvertJavaStringToUTF8(env, name),
base::android::ConvertJavaStringToUTF8(env, value),
base::android::ConvertJavaStringToUTF8(env, domain),
base::android::ConvertJavaStringToUTF8(env, path),
base::Time::FromInternalValue(creation),
base::Time::FromInternalValue(expiration),
- base::Time::FromInternalValue(last_access), secure, httponly,
+ base::Time::FromInternalValue(last_access),
+ secure, httponly,
static_cast<net::CookieSameSite>(same_site),
- static_cast<net::CookiePriority>(priority));
+ static_cast<net::CookiePriority>(priority)));
// The rest must be done from the IO thread.
content::BrowserThread::PostTask(
« no previous file with comments | « no previous file | ios/net/cookies/cookie_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698