net: make CanonicalCookie's constructor private

chrome/browser/android/cookies/cookies_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/time/time.h"
 #include "chrome/browser/android/cookies/cookies_fetcher.h"
@@ skipping 139 matching lines @@
                            jint priority) {
   Profile* profile = ProfileManager::GetPrimaryUserProfile();
   if (!profile->HasOffTheRecordProfile()) {
     return;  // Don't create it. There is nothing to do.
   }
   profile = profile->GetOffTheRecordProfile();
 
   scoped_refptr<net::URLRequestContextGetter> getter(
       profile->GetRequestContext());
 
-  net::CanonicalCookie cookie(
-      GURL(), base::android::ConvertJavaStringToUTF8(env, name),
+  net::CanonicalCookie cookie(*net::CanonicalCookie::Create(
+      GURL("http://example.com"), base::android::ConvertJavaStringToUTF8(env, name),

[mmenke, 2016/07/21 15:34:57]

Should just remove this GURL.  Looks like no tests are running this code, or
they'd fail.  :(

[tfarina, 2016/07/21 19:05:41]

Done.

       base::android::ConvertJavaStringToUTF8(env, value),
       base::android::ConvertJavaStringToUTF8(env, domain),
       base::android::ConvertJavaStringToUTF8(env, path),
       base::Time::FromInternalValue(creation),
       base::Time::FromInternalValue(expiration),
-      base::Time::FromInternalValue(last_access), secure, httponly,
-      static_cast<net::CookieSameSite>(same_site),
-      static_cast<net::CookiePriority>(priority));
+      secure, httponly,
+      static_cast<net::CookieSameSite>(same_site), false,
+      static_cast<net::CookiePriority>(priority)));
 
   // The rest must be done from the IO thread.
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&RestoreToCookieJarInternal, base::RetainedRef(getter),
                  cookie));
 }
 
 // JNI functions
 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   return reinterpret_cast<intptr_t>(new CookiesFetcher(env, obj, 0));
 }
 
 // Register native methods
 bool RegisterCookiesFetcher(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }