Fix a crash on selecting a suggestion.

Fix a crash on selecting a suggestion.

Sometimes the underlying results change after the selection was made and
we crash in updateMatchDestination. Instead, try to find if we still
have an underlying result, and update the index if necessary or just
skip the URL update.

BUG=629124, 595395
Committed: https://crrev.com/0f92cee49214da9099c08d493cc83c3fa7e79dc9
Cr-Commit-Position: refs/heads/master@{#406608}

[Maria, 2016-07-19 22:39:17]

mariakhomenko@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-07-19 22:45:50]

lgtm

https://codereview.chromium.org/2159363002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/2159363002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1647:
if (mSuggestionItems.get(i).getSuggestion() == suggestion) {
instead of == here, I would use .equals.  Since this case handles where the
suggestions have changed, the objects are probably different

[Maria, 2016-07-20 16:48:18]

https://codereview.chromium.org/2159363002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/2159363002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1647:
if (mSuggestionItems.get(i).getSuggestion() == suggestion) {
On 2016/07/19 22:45:50, Ted C wrote:
> instead of == here, I would use .equals.  Since this case handles where the
> suggestions have changed, the objects are probably different

Done.

[Maria, 2016-07-20 16:49:22]

The CQ bit was checked by mariakhomenko@chromium.org

[Maria, 2016-07-20 16:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2159363002/#ps20001
(title: "Switch to equals")

[commit-bot: I haz the power, 2016-07-20 16:49:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:49:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 17:51:54]

Description was changed from

==========
Fix a crash on selecting a suggestion.

Sometimes the underlying results change after the selection was made and
we crash in updateMatchDestination. Instead, try to find if we still
have an underlying result, and update the index if necessary or just
skip the URL update.

BUG=629124,595395
==========

to

==========
Fix a crash on selecting a suggestion.

Sometimes the underlying results change after the selection was made and
we crash in updateMatchDestination. Instead, try to find if we still
have an underlying result, and update the index if necessary or just
skip the URL update.

BUG=629124,595395

Committed: https://crrev.com/0f92cee49214da9099c08d493cc83c3fa7e79dc9
Cr-Commit-Position: refs/heads/master@{#406608}
==========

[commit-bot: I haz the power, 2016-07-20 17:51:55]

Patchset 2 (id:??) landed as
https://crrev.com/0f92cee49214da9099c08d493cc83c3fa7e79dc9
Cr-Commit-Position: refs/heads/master@{#406608}