Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2159353002: [polymer] Remove Polymer.dom() from getAttribute call (Closed)

Created:
4 years, 5 months ago by charliea (OOO until 10-5)
Modified:
4 years, 5 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

[polymer] Remove Polymer.dom() from getAttribute call Polymer.dom'ing is only necessary/possible before setAttribute TBR=sullivan@chromium.org NOPRESUBMIT=true NOTRY=true BUG=catapult:#2285 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e16006cc47c17a79acf382fe3ab296fdbc61995a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tracing/tracing/ui/analysis/analysis_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
charliea (OOO until 10-5)
4 years, 5 months ago (2016-07-19 21:29:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159353002/1
4 years, 5 months ago (2016-07-19 21:29:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e16006cc47c17a79acf382fe3ab296fdbc61995a
4 years, 5 months ago (2016-07-19 21:29:30 UTC) #5
sullivan
4 years, 5 months ago (2016-07-19 21:32:37 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698