Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3742)

Unified Diff: chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc

Issue 2159323003: [MD Feedback] Add placeholder feedback entry point. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per afakhry@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
diff --git a/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc b/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
index 67a56bea726fd6162eaf8cdd12a86bbf1ac57bb8..645618a197d7473e96da3ef36bc3651eb354d1c7 100644
--- a/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
+++ b/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
@@ -7,12 +7,8 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/generated_resources.h"
-#include "content/public/browser/browser_context.h"
-#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui_data_source.h"
#include "grit/browser_resources.h"
-#include "ui/web_dialogs/web_dialog_delegate.h"
-#include "url/gurl.h"
#if !defined(OS_MACOSX)
#include "chrome/browser/ui/browser_dialogs.h"
@@ -20,58 +16,6 @@
namespace {
-// The WebDialogDelegate that specifies what the MD Feedback dialog will look
-// like.
-class MdFeedbackDialogDelegate : public ui::WebDialogDelegate {
- public:
- MdFeedbackDialogDelegate() {}
- ~MdFeedbackDialogDelegate() override {}
-
- ui::ModalType GetDialogModalType() const override {
- return ui::MODAL_TYPE_SYSTEM;
- }
-
- base::string16 GetDialogTitle() const override {
- return base::string16();
- }
-
- GURL GetDialogContentURL() const override {
- return GURL(chrome::kChromeUIFeedbackURL);
- }
-
- void GetWebUIMessageHandlers(
- std::vector<content::WebUIMessageHandler*>* handlers) const override {}
-
- void GetDialogSize(gfx::Size* size) const override {
- // TODO(apacible): Update when WebUI sizing behavior is finalized.
- size->SetSize(400, 600);
- }
-
- std::string GetDialogArgs() const override {
- return std::string();
- }
-
- void OnDialogClosed(const std::string& json_retval) override {
- delete this;
- }
-
- void OnCloseContents(
- content::WebContents* source, bool* out_close_dialog) override {}
-
- bool ShouldShowDialogTitle() const override {
- return false;
- }
-
- bool HandleContextMenu(const content::ContextMenuParams& params) override {
- // Do not show the contextual menu.
- return true;
- }
-};
-
-} // namespace
-
-namespace {
-
content::WebUIDataSource* CreateMdFeedbackUIHTMLSource(Profile* profile) {
content::WebUIDataSource* html_source =
content::WebUIDataSource::Create(chrome::kChromeUIFeedbackHost);
@@ -127,13 +71,3 @@ MdFeedbackUI::MdFeedbackUI(content::WebUI* web_ui)
}
MdFeedbackUI::~MdFeedbackUI() {}
-
-void ShowFeedbackWebDialog(
- content::BrowserContext* browser_context) {
- // TODO(apacible): Platform dependent implementations.
-#if !defined(OS_MACOSX)
- // TODO(apacible): If a feedback dialog is already open, bring that dialog
- // to the front rather than creating a new dialog.
- chrome::ShowWebDialog(NULL, browser_context, new MdFeedbackDialogDelegate());
-#endif // !OS_MACOSX
-}

Powered by Google App Engine
This is Rietveld 408576698