chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.h - Issue 2159323003: [MD Feedback] Add placeholder feedback entry point.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.h

Issue 2159323003: [MD Feedback] Add placeholder feedback entry point. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/feedback/show_feedback_page.cc ('K') | « chrome/browser/feedback/show_feedback_page.cc ('k') | chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.cc » ('j') | chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_MD_FEEDBACK_MD_FEEDBACK_DIALOG_CONTROLLER_H_

	6 #define CHROME_BROWSER_UI_WEBUI_MD_FEEDBACK_MD_FEEDBACK_DIALOG_CONTROLLER_H_

	7

	8 #include "content/public/browser/browser_context.h"

	9

	10 class MdFeedbackDialogController {
	afakhry 2016/08/02 22:15:56 Please document your class, its responsibility and Please document your class, its responsibility and its key functions like Show(). apacible 2016/08/09 22:11:14 Done. Show quoted text On 2016/08/02 22:15:56, afakhry wrote: > Please document your class, its responsibility and its key functions like > Show(). Done.
	11 public:

	12 ~MdFeedbackDialogController();
	afakhry 2016/08/02 22:15:56 You can just say ~MdFeedbackDialogController() = You can just say ~MdFeedbackDialogController() = default; And get rid of the empty implementation in the cc file. apacible 2016/08/09 22:11:14 Done. Show quoted text On 2016/08/02 22:15:56, afakhry wrote: > You can just say > ~MdFeedbackDialogController() = default; > And get rid of the empty implementation in the cc file. Done.
	13

	14 static MdFeedbackDialogController* GetOrCreate();

	15 void Show(content::BrowserContext* browser_context);

	16

	17 private:

	18 MdFeedbackDialogController();

	19

	20 DISALLOW_COPY_AND_ASSIGN(MdFeedbackDialogController);

	21 };

	22

	23 #endif // CHROME_BROWSER_UI_WEBUI_MD_FEEDBACK_MD_FEEDBACK_DIALOG_CONTROLLER_H_

OLD	NEW