Index: base/trace_event/persistent_async_event.h |
diff --git a/base/trace_event/persistent_async_event.h b/base/trace_event/persistent_async_event.h |
new file mode 100644 |
index 0000000000000000000000000000000000000000..7be04caf4d51aea318a226aec13c3834cd42f3eb |
--- /dev/null |
+++ b/base/trace_event/persistent_async_event.h |
@@ -0,0 +1,39 @@ |
+// Copyright 2016 The Chromium Authors. All rights reserved. |
+// Use of this source code is governed by a BSD-style license that can be |
+// found in the LICENSE file. |
+ |
+#ifndef BASE_TRACE_EVENT_PERSISTENT_ASYNC_H_ |
+#define BASE_TRACE_EVENT_PERSISTENT_ASYNC_H_ |
+ |
+#include "base/macros.h" |
+#include "base/time/time.h" |
+#include "base/trace_event/trace_event.h" |
+ |
+namespace base { |
+ |
Primiano Tucci (use gerrit)
2016/09/14 09:38:54
nit: remove this extra space
alexandermont
2016/09/14 20:14:57
Done
|
+namespace trace_event { |
+ |
+class BASE_EXPORT PersistentAsyncEvent |
+ : public trace_event::TraceLog::EnabledStateObserver { |
Primiano Tucci (use gerrit)
2016/09/14 09:38:54
Can this object be created and destroyed on differ
alexandermont
2016/09/14 20:14:56
Done
|
+ public: |
+ PersistentAsyncEvent(const char* category, const char* event_name); |
+ ~PersistentAsyncEvent() override; |
+ |
+ void Begin(); |
+ void End(); |
+ |
+ void OnTraceLogEnabled() override; |
Primiano Tucci (use gerrit)
2016/09/14 09:38:54
nit: add // EnabledStateObserver implementation
A
alexandermont
2016/09/14 20:14:57
Added comment. How could you put these in the priv
Primiano Tucci (use gerrit)
2016/09/15 10:08:29
The TraceLog calls the methods on the base class,
|
+ void OnTraceLogDisabled() override; |
+ |
+ private: |
+ bool active_; |
Primiano Tucci (use gerrit)
2016/09/14 09:38:54
Active seems a redundant field here. If I read the
alexandermont
2016/09/14 20:14:57
Well, actually, start_time doesn't get initialized
Primiano Tucci (use gerrit)
2016/09/15 10:08:29
It does, implicitly.
TimeTicks is a non-POD type a
|
+ void* id_; |
+ const char* category_; |
Primiano Tucci (use gerrit)
2016/09/14 09:38:54
const char* const category_;
ditto for event_name
alexandermont
2016/09/14 20:14:57
I'll put that in there, but what does it do?
Primiano Tucci (use gerrit)
2016/09/15 10:08:29
const char* foo -> foo is a pointer to const char.
|
+ const char* event_name_; |
+ base::TimeTicks start_time_; |
+}; |
Primiano Tucci (use gerrit)
2016/09/14 09:38:54
DISALLOW_COPY_AND_ASSIGN
alexandermont
2016/09/14 20:14:57
Done
|
+ |
+} // namespace trace_event |
+} // namespace base |
+ |
+#endif // BASE_TRACE_EVENT_PERSISTENT_ASYNC_H_ |