Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: src/compiler/pipeline.cc

Issue 2159303002: [turbofan] Improve the store-store elimination. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@p1-base
Patch Set: Fix merge conflict Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/store-store-elimination.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index 862d4086e8565f33b573466f845dc4e2481e184e..86d36a6420b35ca74fb4a73e36d658d6f678e997 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1058,12 +1058,36 @@ struct EffectControlLinearizationPhase {
}
};
+// The store-store elimination greatly benefits from doing a common operator
+// reducer just before it, to eliminate conditional deopts with a constant
+// condition.
+
+struct DeadCodeEliminationPhase {
+ static const char* phase_name() { return "common operator reducer"; }
+
+ void Run(PipelineData* data, Zone* temp_zone) {
+ // Run the common operator reducer.
+ JSGraphReducer graph_reducer(data->jsgraph(), temp_zone);
+ DeadCodeElimination dead_code_elimination(&graph_reducer, data->graph(),
+ data->common());
+ CommonOperatorReducer common_reducer(&graph_reducer, data->graph(),
+ data->common(), data->machine());
+ AddReducer(data, &graph_reducer, &dead_code_elimination);
+ AddReducer(data, &graph_reducer, &common_reducer);
+ graph_reducer.ReduceGraph();
+ }
+};
+
struct StoreStoreEliminationPhase {
- static const char* phase_name() { return "Store-store elimination"; }
+ static const char* phase_name() { return "store-store elimination"; }
void Run(PipelineData* data, Zone* temp_zone) {
- StoreStoreElimination store_store_elimination(data->jsgraph(), temp_zone);
- store_store_elimination.Run();
+ GraphTrimmer trimmer(temp_zone, data->graph());
+ NodeVector roots(temp_zone);
+ data->jsgraph()->GetCachedNodes(&roots);
+ trimmer.TrimGraph(roots.begin(), roots.end());
+
+ StoreStoreElimination::Run(data->jsgraph(), temp_zone);
}
};
@@ -1554,6 +1578,9 @@ bool PipelineImpl::OptimizeGraph(Linkage* linkage) {
Run<EffectControlLinearizationPhase>();
RunPrintAndVerify("Effect and control linearized", true);
+ Run<DeadCodeEliminationPhase>();
+ RunPrintAndVerify("Common operator reducer", true);
+
if (FLAG_turbo_store_elimination) {
Run<StoreStoreEliminationPhase>();
RunPrintAndVerify("Store-store elimination", true);
« no previous file with comments | « no previous file | src/compiler/store-store-elimination.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698