Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3295)

Unified Diff: chrome/renderer/BUILD.gn

Issue 2159283003: [WIP][DO NOT LAND] Componentize spellcheck Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/spellcheck_result.h ('k') | chrome/renderer/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/BUILD.gn
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
index fc1868e6e96899fb4e32ffbba55d181dc052c028..c4ffb611f6dd59543408ee2aaf6daed30d960a5c 100644
--- a/chrome/renderer/BUILD.gn
+++ b/chrome/renderer/BUILD.gn
@@ -154,6 +154,7 @@ static_library("renderer") {
if (enable_spellcheck) {
sources +=
rebase_path(gypi_values.chrome_renderer_spellchecker_sources, ".", "..")
+ deps += [ "//components/spellcheck/renderer" ]
if (!is_android) {
deps += [ "//third_party/hunspell" ]
}
@@ -178,12 +179,12 @@ static_library("renderer") {
if (is_win) {
deps += [ "//third_party/wtl" ]
}
- if (is_android) {
- sources -= [
- "spellchecker/hunspell_engine.cc",
- "spellchecker/hunspell_engine.h",
- ]
- }
+# if (is_android) {
+# sources -= [
+# "spellchecker/hunspell_engine.cc",
+# "spellchecker/hunspell_engine.h",
+# ]
+# }
}
# In GYP this is part of test_support_common.
« no previous file with comments | « chrome/common/spellcheck_result.h ('k') | chrome/renderer/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698