Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: chrome/browser/spellchecker/misspelling.cc

Issue 2159283003: [WIP][DO NOT LAND] Componentize spellcheck Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/misspelling.h ('k') | chrome/browser/spellchecker/misspelling_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/misspelling.cc
diff --git a/chrome/browser/spellchecker/misspelling.cc b/chrome/browser/spellchecker/misspelling.cc
deleted file mode 100644
index ddf3fa01e6a4e08dcc4873a86e6bb42ce5efc7b1..0000000000000000000000000000000000000000
--- a/chrome/browser/spellchecker/misspelling.cc
+++ /dev/null
@@ -1,86 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-//
-// The |Misspelling| object stores the misspelling, a spellcheck suggestion for
-// it, and user's action on it. The misspelling is stored as |context|,
-// |location|, and |length| instead of only misspelled text, because the
-// spellcheck algorithm uses the context.
-
-#include "chrome/browser/spellchecker/misspelling.h"
-
-#include "base/strings/string_number_conversions.h"
-#include "base/values.h"
-
-namespace {
-
-// Builds a value from a list of spellcheck suggestions.
-std::unique_ptr<base::Value> BuildSuggestionsValue(
- const std::vector<base::string16>& list) {
- std::unique_ptr<base::ListValue> result(new base::ListValue);
- result->AppendStrings(list);
- return std::move(result);
-}
-
-// Builds a value from a spellcheck action.
-std::unique_ptr<base::Value> BuildUserActionValue(
- const SpellcheckAction& action) {
- std::unique_ptr<base::ListValue> result(new base::ListValue);
- result->Append(action.Serialize());
- return std::move(result);
-}
-
-} // namespace
-
-Misspelling::Misspelling()
- : location(0), length(0), hash(0), timestamp(base::Time::Now()) {}
-
-Misspelling::Misspelling(const base::string16& context,
- size_t location,
- size_t length,
- const std::vector<base::string16>& suggestions,
- uint32_t hash)
- : context(context),
- location(location),
- length(length),
- suggestions(suggestions),
- hash(hash),
- timestamp(base::Time::Now()) {}
-
-Misspelling::Misspelling(const Misspelling& other) = default;
-
-Misspelling::~Misspelling() {}
-
-std::unique_ptr<base::DictionaryValue> SerializeMisspelling(
- const Misspelling& misspelling) {
- std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
- result->SetString(
- "timestamp",
- base::Int64ToString(static_cast<long>(misspelling.timestamp.ToJsTime())));
- result->SetInteger("misspelledLength", misspelling.length);
- result->SetInteger("misspelledStart", misspelling.location);
- result->SetString("originalText", misspelling.context);
- result->SetString("suggestionId", base::UintToString(misspelling.hash));
- result->Set("suggestions",
- BuildSuggestionsValue(misspelling.suggestions).release());
- result->Set("userActions",
- BuildUserActionValue(misspelling.action).release());
- return result;
-}
-
-base::string16 GetMisspelledString(const Misspelling& misspelling) {
- // Feedback sender does not create Misspelling objects for spellcheck results
- // that are out-of-bounds of checked text length.
- if (misspelling.location > misspelling.context.length())
- return base::string16();
- return misspelling.context.substr(misspelling.location, misspelling.length);
-}
-
-size_t ApproximateSerializedSize(const Misspelling& misspelling) {
- // Estimated by eyeballing JSON overhead.
- const size_t kNumberOfOverheadBytes = 180;
- size_t result = misspelling.context.length() + kNumberOfOverheadBytes;
- for (const base::string16& suggestion : misspelling.suggestions)
- result += suggestion.size();
- return result;
-}
« no previous file with comments | « chrome/browser/spellchecker/misspelling.h ('k') | chrome/browser/spellchecker/misspelling_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698