Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2159283003: [WIP][DO NOT LAND] Componentize spellcheck

Created:
4 years, 5 months ago by timvolodine
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, rlp+watch_chromium.org, rouslan+spell_chromium.org, groby+spellwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP][DO NOT LAND] Componentize spellcheck Work in progress, DO NOT LAND. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+688 lines, -10982 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/spellchecker/SpellCheckerSessionBridge.java View 1 chunk +0 lines, -122 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/spellchecker/feedback.h View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/spellchecker/feedback.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/spellchecker/feedback_sender.h View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/spellchecker/feedback_sender.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D chrome/browser/spellchecker/feedback_sender_unittest.cc View 1 chunk +0 lines, -729 lines 0 comments Download
D chrome/browser/spellchecker/feedback_unittest.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D chrome/browser/spellchecker/misspelling.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/spellchecker/misspelling.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/spellchecker/misspelling_unittest.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_action.h View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_action.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_action_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc View 31 chunks +67 lines, -66 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_dictionary.h View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.cc View 2 chunks +7 lines, -6 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_host_metrics.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_host_metrics.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 5 chunks +9 lines, -5 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_message_filter_platform.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_platform.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_platform_android.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_platform_mac.mm View 1 chunk +0 lines, -309 lines 0 comments Download
D chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 1 chunk +0 lines, -396 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 13 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/spellchecker/spellchecker_session_bridge_android.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/spellchecker/spellchecker_session_bridge_android.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/spellchecker/spelling_service_client.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +0 lines, -282 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 7 chunks +14 lines, -13 lines 0 comments Download
D chrome/browser/spellchecker/word_trimmer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/spellchecker/word_trimmer.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/spellchecker/word_trimmer_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +21 lines, -22 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/pref_names.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/common/spellcheck_bdict_language.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/common/spellcheck_common.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/common/spellcheck_common.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D chrome/common/spellcheck_marker.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/common/spellcheck_messages.h View 1 chunk +0 lines, -148 lines 0 comments Download
D chrome/common/spellcheck_result.h View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/renderer/spellchecker/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/renderer/spellchecker/custom_dictionary_engine.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/renderer/spellchecker/custom_dictionary_engine.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/renderer/spellchecker/hunspell_engine.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/renderer/spellchecker/platform_spelling_engine.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/renderer/spellchecker/platform_spelling_engine.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck.h View 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck.cc View 1 chunk +0 lines, -548 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_language.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_language.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_multilingual_unittest.cc View 1 chunk +0 lines, -256 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_provider.h View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_provider.cc View 1 chunk +0 lines, -360 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_provider_test.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_provider_test.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +0 lines, -1571 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_worditerator.h View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 chunk +0 lines, -445 lines 0 comments Download
D chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 chunk +0 lines, -508 lines 0 comments Download
D chrome/renderer/spellchecker/spelling_engine.h View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
A + components/spellcheck/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/spellcheck/android/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/spellcheck/android/component_jni_registrar.h View 1 chunk +21 lines, -0 lines 0 comments Download
A components/spellcheck/android/component_jni_registrar.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A + components/spellcheck/android/java/src/org/chromium/components/spellcheck/SpellCheckerSessionBridge.java View 2 chunks +3 lines, -1 line 0 comments Download
A components/spellcheck/browser/BUILD.gn View 1 chunk +88 lines, -0 lines 0 comments Download
A + components/spellcheck/browser/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/feedback.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/feedback.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/feedback_sender.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/spellcheck/browser/feedback_sender.cc View 6 chunks +10 lines, -10 lines 0 comments Download
A + components/spellcheck/browser/feedback_sender_unittest.cc View 4 chunks +10 lines, -8 lines 0 comments Download
A + components/spellcheck/browser/feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/misspelling.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/misspelling.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/misspelling_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/spellcheck/browser/pref_names.h View 1 chunk +19 lines, -0 lines 0 comments Download
A components/spellcheck/browser/pref_names.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_action.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_action.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/spellcheck_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/spellcheck_dictionary.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_host_metrics.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_host_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/spellcheck_host_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/spellcheck_message_filter_platform.h View 1 chunk +4 lines, -2 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_message_filter_platform_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_platform.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_platform_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_platform_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/spellcheck/browser/spellcheck_platform_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/spellcheck/browser/spellchecker_session_bridge_android.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/spellchecker_session_bridge_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/spellcheck/browser/spelling_service_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/spelling_service_client.cc View 4 chunks +9 lines, -9 lines 0 comments Download
A + components/spellcheck/browser/word_trimmer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/browser/word_trimmer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/browser/word_trimmer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/spellcheck/common/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A components/spellcheck/common/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/spellcheck/common/spellcheck_bdict_language.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/common/spellcheck_common.h View 2 chunks +0 lines, -2 lines 0 comments Download
A + components/spellcheck/common/spellcheck_common.cc View 3 chunks +2 lines, -3 lines 0 comments Download
A + components/spellcheck/common/spellcheck_marker.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/common/spellcheck_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/spellcheck/common/spellcheck_result.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/spellcheck/renderer/BUILD.gn View 1 chunk +55 lines, -0 lines 0 comments Download
A components/spellcheck/renderer/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/spellcheck/renderer/custom_dictionary_engine.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/renderer/custom_dictionary_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/custom_dictionary_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/hunspell_engine.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/spellcheck/renderer/hunspell_engine.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/spellcheck/renderer/platform_spelling_engine.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/platform_spelling_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/spellcheck.cc View 3 chunks +9 lines, -8 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_language.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/spellcheck_language.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_multilingual_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_provider.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_provider.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_provider_hunspell_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_provider_mac_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_provider_test.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/spellcheck_provider_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_worditerator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_worditerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/spellcheck/renderer/spellcheck_worditerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/spellcheck/renderer/spelling_engine.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +13 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698