Converted Observatory top-nav-menu element

Converted Observatory top-nav-menu element

R=johnmccutchan@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/4cb0cd442c6dc1edf9bd129db2d03c9eadb6b124

[cbernaschina, 2016-07-20 03:29:56]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[Cutch, 2016-07-20 13:50:45]

https://codereview.chromium.org/2159273003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart (right):

https://codereview.chromium.org/2159273003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart:26: _last =
getAttribute('') != null;
what is this checking?

[cbernaschina, 2016-07-20 17:17:00]

https://codereview.chromium.org/2159273003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart (right):

https://codereview.chromium.org/2159273003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart:26: _last =
getAttribute('') != null;
On 2016/07/20 13:50:45, Cutch wrote:
> what is this checking?

It is checking the presence of the attribute.
If it is not set _last is false, if it is set to a non binding value we assign
true. If there is binding this will actually have no effect.

[cbernaschina, 2016-07-20 17:56:13]

https://codereview.chromium.org/2159273003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart (right):

https://codereview.chromium.org/2159273003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart:26: _last =
getAttribute('') != null;
On 2016/07/20 13:50:45, Cutch wrote:
> what is this checking?

Done.

[Cutch, 2016-07-20 21:11:59]

lgtm

[rmacnak, 2016-07-21 23:23:09]

lgtm w/c

https://chromiumcodereview.appspot.com/2159273003/diff/60001/runtime/observat...
File runtime/observatory/lib/src/elements/nav/top_menu.dart (right):

https://chromiumcodereview.appspot.com/2159273003/diff/60001/runtime/observat...
runtime/observatory/lib/src/elements/nav/top_menu.dart:36: void attached() {
super.attached(); _r.enable(); }
Separate lines.

https://chromiumcodereview.appspot.com/2159273003/diff/60001/runtime/observat...
runtime/observatory/lib/src/elements/nav/top_menu.dart:40: super.detached();
_r.disable(notify: true);
Separate lines.

[cbernaschina, 2016-07-21 23:47:35]

https://codereview.chromium.org/2159273003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/nav/top_menu.dart (right):

https://codereview.chromium.org/2159273003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/nav/top_menu.dart:36: void attached() {
super.attached(); _r.enable(); }
On 2016/07/21 23:23:09, rmacnak wrote:
> Separate lines.

Done.

https://codereview.chromium.org/2159273003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/nav/top_menu.dart:40: super.detached();
_r.disable(notify: true);
On 2016/07/21 23:23:09, rmacnak wrote:
> Separate lines.

Done.

[cbernaschina, 2016-07-22 00:20:09]

Description was changed from

==========
Converted Observatory top-nav-menu element
==========

to

==========
Converted Observatory top-nav-menu element

R=johnmccutchan@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4cb0cd442c6dc1edf9bd129db2d03c9eadb6b124
==========

[cbernaschina, 2016-07-22 00:20:11]

Committed patchset #5 (id:80001) manually as
4cb0cd442c6dc1edf9bd129db2d03c9eadb6b124 (presubmit successful).