Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2159253006: DevTools: Set mouse cursor to default when hovering over color swatch (Closed)

Created:
4 years, 5 months ago by flandy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Set mouse cursor to default when hovering over color swatch The mouse pointer should change to indicate that you can click on the swatch. R=lushnikov Committed: https://crrev.com/b3d5944103f2e7b44dfac6c4204b7e74b660b9a6 Cr-Commit-Position: refs/heads/master@{#406904}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move property to .color-swatch-inner { #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/colorSwatch.css View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
flandy
Please take a look
4 years, 5 months ago (2016-07-20 23:57:14 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/2159253006/diff/1/third_party/WebKit/Source/devtools/front_end/ui/colorSwatch.css File third_party/WebKit/Source/devtools/front_end/ui/colorSwatch.css (right): https://codereview.chromium.org/2159253006/diff/1/third_party/WebKit/Source/devtools/front_end/ui/colorSwatch.css#newcode33 third_party/WebKit/Source/devtools/front_end/ui/colorSwatch.css:33: cursor: default; nit: let's move this to .color-swatch-inner ...
4 years, 5 months ago (2016-07-21 00:56:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159253006/20001
4 years, 5 months ago (2016-07-21 01:06:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/204855)
4 years, 5 months ago (2016-07-21 01:28:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159253006/20001
4 years, 5 months ago (2016-07-21 16:49:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 18:08:56 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:11:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3d5944103f2e7b44dfac6c4204b7e74b660b9a6
Cr-Commit-Position: refs/heads/master@{#406904}

Powered by Google App Engine
This is Rietveld 408576698