Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make constant private Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/v8_browsing.py ('k') | tools/perf/page_sets/system_health/loading_stories.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/system_health/browsing_stories.py
diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py
index 388e0ee5c3ea0c46d6988163c40715dbe8192216..c04bf1423e3fb602b9303ea79a941f639d39a5f7 100644
--- a/tools/perf/page_sets/system_health/browsing_stories.py
+++ b/tools/perf/page_sets/system_health/browsing_stories.py
@@ -180,8 +180,15 @@ class WashingtonPostMobileStory(_NewsBrowsingStory):
IS_SINGLE_PAGE_APP = True
ITEM_SELECTOR = '.hed > a'
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
+ _CLOSE_BUTTON_SELECTOR = '.close'
def _DidLoadDocument(self, action_runner):
- # Close the popup window.
- action_runner.ClickElement(selector='.close')
+ # Close the popup window. On Nexus 9 (and probably other tables) the popup
+ # window does not have a "Close" button, instead it has only a "Send link
+ # to phone" button. So on tablets we run with the popup window open. The
+ # popup is transparent, so this is mostly an aesthetical issue.
+ has_button = action_runner.EvaluateJavaScript(
+ '!!document.querySelector("%s")' % self._CLOSE_BUTTON_SELECTOR)
+ if has_button:
+ action_runner.ClickElement(selector=self._CLOSE_BUTTON_SELECTOR)
super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)
« no previous file with comments | « tools/perf/benchmarks/v8_browsing.py ('k') | tools/perf/page_sets/system_health/loading_stories.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698