Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2159233002: User menu button icon tweaks (Closed)

Created:
4 years, 5 months ago by Jane
Modified:
4 years, 5 months ago
Reviewers:
*sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

User menu button icon tweaks This is for material design desktop user menu only. Specifically: 1. Tweaked the icon-title spacing in option buttons; 2. Changed the "Exit Guest" icon. See mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-1.png%3Fc=show (Comment #8 discusses these tweaks.) See comparative screenshots: https://drive.google.com/a/google.com/folderview?id=0B7Fvv7JszRyGZnlYMzc2QnJMbzA&usp=sharing BUG=615893 Committed: https://crrev.com/1adbbce30aaff8ea555181506404bac76de99ff6 Cr-Commit-Position: refs/heads/master@{#406464}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 6 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Jane
Hi Scott, small change, PTAL. Thanks!
4 years, 5 months ago (2016-07-19 14:43:08 UTC) #3
sky
LGTM https://codereview.chromium.org/2159233002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/2159233002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1744 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1744: text = browser_->profile()->IsGuestSession() ? nit: how about a ...
4 years, 5 months ago (2016-07-19 17:57:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159233002/20001
4 years, 5 months ago (2016-07-20 02:14:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 02:19:03 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 02:19:09 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 02:20:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1adbbce30aaff8ea555181506404bac76de99ff6
Cr-Commit-Position: refs/heads/master@{#406464}

Powered by Google App Engine
This is Rietveld 408576698