Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2159223004: Revert of Move Error methods to C++ (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Move Error methods to C++ (patchset #11 id:200001 of https://codereview.chromium.org/2142933003/ ) Reason for revert: Clusterfuzz failures: https://bugs.chromium.org/p/chromium/issues/detail?id=629749 Original issue's description: > Move Error methods to C++ > > This ports a large portion of Error methods to C++, > including the constructor, stack setter and getter, > and Error.prototype.toString. > > BUG= > > Committed: https://crrev.com/5742da056a290caa13a0b8717ddb1e43424e0d31 > Cr-Commit-Position: refs/heads/master@{#37870} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8c163cfe45db6152a6cbc6f165badfdd30210179 Cr-Commit-Position: refs/heads/master@{#37881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -489 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/accessors.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +35 lines, -79 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -5 lines 0 comments Download
D src/builtins/builtins-error.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-symbols.h View 6 chunks +1 line, -7 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.cc View 5 chunks +21 lines, -55 lines 0 comments Download
M src/js/messages.js View 4 chunks +108 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 1 chunk +6 lines, -6 lines 0 comments Download
M test/mjsunit/debug-function-scopes.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1980.js View 2 chunks +1 line, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-599067.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/stack-traces-overflow.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jgruber
Created Revert of Move Error methods to C++
4 years, 5 months ago (2016-07-20 06:41:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159223004/1
4 years, 5 months ago (2016-07-20 06:41:34 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-20 06:41:36 UTC) #5
Yang
On 2016/07/20 06:41:36, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 5 months ago (2016-07-20 06:42:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159223004/1
4 years, 5 months ago (2016-07-20 06:42:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 06:43:12 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 06:46:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c163cfe45db6152a6cbc6f165badfdd30210179
Cr-Commit-Position: refs/heads/master@{#37881}

Powered by Google App Engine
This is Rietveld 408576698