Issue 21592002: Add fullscreen rect bench

LGTM + nits https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp File bench/FSRectBench.cpp (right): https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp#newcode13 bench/FSRectBench.cpp:13: comment r.e. what it is supposed ...

7 years, 4 months ago (2013-08-01 17:50:14 UTC) #3

bsalomon

Committed patchset #2 manually as r10510 (presubmit successful).

7 years, 4 months ago (2013-08-02 14:39:31 UTC) #4

bsalomon

7 years, 4 months ago (2013-08-02 19:35:09 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp
File bench/FSRectBench.cpp (right):

https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp#newc...
bench/FSRectBench.cpp:13: 
On 2013/08/01 17:50:14, robertphillips wrote:
> comment r.e. what it is supposed to hit?

Done.

https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp#newc...
bench/FSRectBench.cpp:17: : INHERITED(param) {
On 2013/08/01 17:50:14, robertphillips wrote:
> MWC?

Done.

https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp#newc...
bench/FSRectBench.cpp:19: static const SkScalar kMinOffset = 0;
On 2013/08/01 17:50:14, robertphillips wrote:
> Move this setup out of the ctor and into onPreDraw?

Done.

https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp#newc...
bench/FSRectBench.cpp:21: static const SkScalar kOffsetRange = kMaxOffset -
kMinOffset;
On 2013/08/01 17:50:14, robertphillips wrote:
> pre++?

Done.

https://codereview.chromium.org/21592002/diff/3001/bench/FSRectBench.cpp#newc...
bench/FSRectBench.cpp:34: SkPaint paint;
On 2013/08/01 17:50:14, robertphillips wrote:
> pre++?

Done.

Expand Messages | Collapse Messages

Issue 21592002: Add fullscreen rect bench (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove skstring #

Messages