Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2159183003: Revert "Don't call _ensureRequestAnimationFrame in Dartium." (Closed)

Created:
4 years, 5 months ago by Bill Hesse
Modified:
4 years, 5 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, kevmoo, mit
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Don't call _ensureRequestAnimationFrame in Dartium." This reverts commit bf8eeef6a08e2b36c83f6d14a4200f87b0e8cc1d. Revert "Fix animationFrameRequest for dartium." This reverts commit 3daaf3849fd38435e09bbe4ee2171e03b5568798. BUG=https://github.com/dart-lang/sdk/issues/26906 Committed: https://github.com/dart-lang/sdk/commit/bde8d3efc6f7558edda6a1cad879ff4a264ddabe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +2 lines, -46 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
TBR=terry@google.com
4 years, 5 months ago (2016-07-19 11:56:10 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as bde8d3efc6f7558edda6a1cad879ff4a264ddabe (presubmit successful).
4 years, 5 months ago (2016-07-19 11:57:48 UTC) #4
terry
4 years, 5 months ago (2016-07-19 13:27:52 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698