Attaching an image to many color attachment points is unsupported

gpu/command_buffer/service/framebuffer_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "gpu/command_buffer/service/error_state_mock.h"
 #include "gpu/command_buffer/service/feature_info.h"
 #include "gpu/command_buffer/service/framebuffer_manager.h"
@@ skipping 1476 matching lines @@
   framebuffer_->GetStatus(texture_manager_.get(), GL_READ_FRAMEBUFFER);
 
   // Check Unbinding does not call CheckFramebufferStatus
   framebuffer_->UnbindRenderbuffer(GL_RENDERBUFFER, renderbuffer1);
   framebuffer_->GetStatus(texture_manager_.get(), GL_READ_FRAMEBUFFER);
 }
 
 class FramebufferInfoES3Test : public FramebufferInfoTestBase {
  public:
   FramebufferInfoES3Test() : FramebufferInfoTestBase(CONTEXT_TYPE_WEBGL2) {}
+
+ protected:
+  void SetUp() override {
+    InitializeContext("OpenGL ES 3.0", "");
+  }
+
+  void InitializeContext(const char* gl_version, const char* extensions) {
+    GpuServiceTest::SetUpWithGLVersion(gl_version, extensions);
+    TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(gl_.get(),
+        extensions, "", gl_version);
+    feature_info_->InitializeForTesting(CONTEXT_TYPE_OPENGLES3);

[qiankun, 2016/07/20 15:03:26]

Is it Ok for you to test GLES3 context now? I may update ES2/WebGL 1 +
EXT_draw_buffers next time when conformance test for that is ready.

[Zhenyao Mo, 2016/07/20 16:10:42]

This is good. I think between this and the WebGL side testing, we are well
covered.

+    decoder_.reset(new MockGLES2Decoder());
+    manager_.CreateFramebuffer(kClient1Id, kService1Id);
+    error_state_.reset(new ::testing::StrictMock<gles2::MockErrorState>());
+    framebuffer_ = manager_.GetFramebuffer(kClient1Id);
+    ASSERT_TRUE(framebuffer_ != NULL);
+  }
 };
 
 TEST_F(FramebufferInfoES3Test, DifferentDimensions) {
   const GLuint kRenderbufferClient1Id = 33;
   const GLuint kRenderbufferService1Id = 333;
   const GLuint kRenderbufferClient2Id = 34;
   const GLuint kRenderbufferService2Id = 334;
   const GLsizei kWidth1 = 16;
   const GLsizei kHeight1 = 32;
   const GLenum kFormat1 = GL_RGBA4;
@@ skipping 24 matching lines @@
       renderbuffer_manager_->GetRenderbuffer(kRenderbufferClient2Id);
   ASSERT_TRUE(renderbuffer2 != NULL);
   renderbuffer_manager_->SetInfo(
       renderbuffer2, kSamples2, kFormat2, kWidth2, kHeight2);
   framebuffer_->AttachRenderbuffer(GL_DEPTH_ATTACHMENT, renderbuffer2);
 
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT),
             framebuffer_->IsPossiblyComplete(feature_info_.get()));
 }
 
+TEST_F(FramebufferInfoES3Test, DuplicatedAttachments) {
+  const GLuint kTextureClientId = 33;
+  const GLuint kTextureServiceId = 333;
+  const GLenum kTarget = GL_TEXTURE_2D;
+  const GLint kLevel = 0;
+  const GLenum kFormat = GL_RGBA;
+  const GLenum kType = GL_UNSIGNED_BYTE;
+  const GLint kWidth = 16;
+  const GLint kHeight = 32;
+  const GLint kDepth = 1;
+  const GLint kBorder = 0;
+  const GLint kSamples = 0;
+
+  texture_manager_->CreateTexture(kTextureClientId, kTextureServiceId);
+  scoped_refptr<TextureRef> texture(
+      texture_manager_->GetTexture(kTextureClientId));
+  ASSERT_TRUE(texture.get() != nullptr);
+  texture_manager_->SetTarget(texture.get(), GL_TEXTURE_2D);
+  texture_manager_->SetLevelInfo(texture.get(), GL_TEXTURE_2D, kLevel,
+                                 kFormat, kWidth, kHeight, kDepth, kBorder,
+                                 kFormat, kType, gfx::Rect());
+
+  // Check an image is attached to more than one color attachment point
+  // in a framebuffer.
+  framebuffer_->AttachTexture(
+      GL_COLOR_ATTACHMENT0, texture.get(), kTarget, kLevel, kSamples);
+  framebuffer_->AttachTexture(
+      GL_COLOR_ATTACHMENT1, texture.get(), kTarget, kLevel, kSamples);
+  EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_UNSUPPORTED),
+      framebuffer_->IsPossiblyComplete(feature_info_.get()));
+}
+
 TEST_F(FramebufferInfoES3Test, ReadBuffer) {
   const GLuint kRenderbufferClientId = 33;
   const GLuint kRenderbufferServiceId = 333;
 
   EXPECT_EQ(static_cast<GLenum>(GL_COLOR_ATTACHMENT0),
             framebuffer_->read_buffer());
   framebuffer_->set_read_buffer(GL_NONE);
   EXPECT_EQ(static_cast<GLenum>(GL_NONE), framebuffer_->read_buffer());
   EXPECT_FALSE(framebuffer_->GetReadBufferAttachment());
 
   framebuffer_->set_read_buffer(GL_COLOR_ATTACHMENT1);
   EXPECT_FALSE(framebuffer_->GetReadBufferAttachment());
 
   renderbuffer_manager_->CreateRenderbuffer(
       kRenderbufferClientId, kRenderbufferServiceId);
   Renderbuffer* renderbuffer =
       renderbuffer_manager_->GetRenderbuffer(kRenderbufferClientId);
   ASSERT_TRUE(renderbuffer != NULL);
   framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT1, renderbuffer);
   EXPECT_TRUE(framebuffer_->GetReadBufferAttachment());
 }
 
 }  // namespace gles2
 }  // namespace gpu