content/browser/storage_partition_impl.h - Issue 2159133002: Shutdown StoragePartition before ProfileIOData is being shut down

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/storage_partition_impl.h

Issue 2159133002: Shutdown StoragePartition before ProfileIOData is being shut down (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | content/browser/storage_partition_impl_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/storage_partition_impl.h

diff --git a/content/browser/storage_partition_impl.h b/content/browser/storage_partition_impl.h

index 9ca0293c7bcf3e795dcdcd677ac87d6952788acd..10863139d39c738ccc8291c3e1b11fbdcb37673d 100644

--- a/content/browser/storage_partition_impl.h

+++ b/content/browser/storage_partition_impl.h

@@ -34,6 +34,9 @@ class CONTENT_EXPORT StoragePartitionImpl

: public StoragePartition,

public NON_EXPORTED_BASE(mojom::StoragePartitionService) {

public:

+ // It is guaranteed that storage partitions are destructed before the

+ // browser context starts shutting down its corresponding IO thread residents

+ // (e.g. resource context).

~StoragePartitionImpl() override;

// Quota managed data uses a different bitmask for types than

« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | content/browser/storage_partition_impl_map.cc » ('j') | no next file with comments »