Shutdown StoragePartition before ProfileIOData is being shut down

content/browser/browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/browser_context.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <algorithm>
 #include <limits>
@@ skipping 468 matching lines @@
   if (!connection_holder)
     return nullptr;
   return connection_holder->shell_connection()->GetConnector();
 }
 
 BrowserContext::~BrowserContext() {
   CHECK(GetUserData(kMojoWasInitialized))
       << "Attempting to destroy a BrowserContext that never called "
       << "Initialize()";
 
+  DCHECK(!GetUserData(kStoragePartitionMapKeyName))
+      << "StoragePartitionMap is not shut down properly";
+
   RemoveBrowserContextFromUserIdMap(this);
 
   if (GetUserData(kDownloadManagerKeyName))
     GetDownloadManager(this)->Shutdown();
 }
 
+void BrowserContext::ShutdownStoragePartitions() {
+  if (GetUserData(kStoragePartitionMapKeyName))
+    RemoveUserData(kStoragePartitionMapKeyName);

[mmenke, 2016/07/19 17:55:20]

Storage partitions are stored as user data attached to the BrowserContext?  I
don't suppose there are plans to change that?

[kinuko, 2016/07/21 03:06:25]

I suppose we wanted to avoid exposing internal stuff at BrowserContext's public
header?  I don't like UserData approach too much but I want to explorer other
options separately from this change.

[mmenke, 2016/07/21 15:27:20]

I didn't mean to suggest you make that part of this change, was just hoping that
since you seem to be working on the code, you might want to consider changing
the ownership model.

+}
+
 }  // namespace content