Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2159113002: [debug] use correct language mode when parsing eval for scope iterator. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] use correct language mode when parsing eval for scope iterator. R=mstarzinger@chromium.org BUG=v8:5207 Committed: https://crrev.com/7c3ddd2cf4a24247d3ffc7f5e641d5d558c66ac1 Cr-Commit-Position: refs/heads/master@{#37857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/debug/debug-scopes.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 5 months ago (2016-07-19 07:04:55 UTC) #1
Michael Starzinger
LGTM.
4 years, 5 months ago (2016-07-19 08:31:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159113002/1
4 years, 5 months ago (2016-07-19 08:50:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 09:54:36 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 09:55:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c3ddd2cf4a24247d3ffc7f5e641d5d558c66ac1
Cr-Commit-Position: refs/heads/master@{#37857}

Powered by Google App Engine
This is Rietveld 408576698